MainFrame scrollbars should work with RFV instead of FV

third_party/WebKit/Source/core/frame/RootFrameViewport.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef RootFrameViewport_h
 #define RootFrameViewport_h
 
 #include "core/CoreExport.h"
 #include "platform/scroll/ScrollableArea.h"
 
@@ skipping 46 matching lines @@
   void setScrollOffset(const ScrollOffset&,
                        ScrollType,
                        ScrollBehavior = ScrollBehaviorInstant) override;
   LayoutRect scrollIntoView(const LayoutRect& rectInContent,
                             const ScrollAlignment& alignX,
                             const ScrollAlignment& alignY,
                             ScrollType = ProgrammaticScroll) override;
   IntRect visibleContentRect(
       IncludeScrollbarsInRect = ExcludeScrollbars) const override;
   bool shouldUseIntegerScrollOffset() const override;
-  LayoutRect visualRectForScrollbarParts() const override {
-    ASSERT_NOT_REACHED();
-    return LayoutRect();
-  }
-  bool isActive() const override;
   int scrollSize(ScrollbarOrientation) const override;
   bool isScrollCornerVisible() const override;
   IntRect scrollCornerRect() const override;
   void updateScrollOffset(const ScrollOffset&, ScrollType) override;
   IntSize scrollOffsetInt() const override;
   ScrollOffset scrollOffset() const override;
   IntSize minimumScrollOffsetInt() const override;
   IntSize maximumScrollOffsetInt() const override;
   ScrollOffset maximumScrollOffset() const override;
   IntSize contentsSize() const override;
@@ skipping 11 matching lines @@
   bool scrollAnimatorEnabled() const override;
   HostWindow* getHostWindow() const override;
   void serviceScrollAnimations(double) override;
   void updateCompositorScrollAnimations() override;
   void cancelProgrammaticScrollAnimation() override;
   ScrollBehavior scrollBehaviorStyle() const override;
   Widget* getWidget() override;
   void clearScrollAnimators() override;
   LayoutBox* layoutBox() const override;
 
+  // Scrollbar related

[bokan, 2016/10/31 15:25:09]

I think we should have a separate interface from ScrollableArea for a
ScrollbarController, ScrollableArea is too big and general. Might be easier in a
follow up CL though.

[ymalik, 2016/11/03 18:49:12]

Agreed. Added a TODO for cleanup.

+  bool isActive() const override;
+  bool hasOverlayScrollbars() const override;
+  void setScrollbarNeedsPaintInvalidation(ScrollbarOrientation) override;
+  LayoutRect visualRectForScrollbarParts() const override;
+  ScrollbarOverlayColorTheme getScrollbarOverlayColorTheme() const override;
+  void getTickmarks(Vector<IntRect>& rects) const override;
+  void mouseEnteredScrollbar(Scrollbar&) const override;
+  void mouseExitedScrollbar(Scrollbar&) const override;
+  void scrollbarVisibilityChanged() override;
+  IntRect convertFromScrollbarToContainingWidget(const Scrollbar&,
+                                                 const IntRect&) const override;
+  IntRect convertFromContainingWidgetToScrollbar(const Scrollbar&,
+                                                 const IntRect&) const override;
+  IntPoint convertFromScrollbarToContainingWidget(
+      const Scrollbar&,
+      const IntPoint&) const override;
+  IntPoint convertFromContainingWidgetToScrollbar(
+      const Scrollbar&,
+      const IntPoint&) const override;
+  ScrollOffset scrollAnimatorDesiredTargetOffset() const override;
+  void setScrollCornerNeedsPaintInvalidation() override;
+
+  void setTickmarks(const Vector<IntRect>&);
+
  private:
   RootFrameViewport(ScrollableArea& visualViewport,
                     ScrollableArea& layoutViewport);
 
   enum ViewportToScrollFirst { VisualViewport, LayoutViewport };
 
   ScrollOffset scrollOffsetFromScrollAnimators() const;
 
   void distributeScrollBetweenViewports(const ScrollOffset&,
                                         ScrollType,
                                         ScrollBehavior,
                                         ViewportToScrollFirst);
 
   // If either of the layout or visual viewports are scrolled explicitly (i.e.
   // not through this class), their updated offset will not be reflected in this
   // class' animator so use this method to pull updated values when necessary.
   void updateScrollAnimator();
 
   ScrollableArea& visualViewport() const {
     ASSERT(m_visualViewport);
     return *m_visualViewport;
   }
 
+  Vector<IntRect> m_tickmarks;
+
   Member<ScrollableArea> m_visualViewport;
   Member<ScrollableArea> m_layoutViewport;
 };
 
 DEFINE_TYPE_CASTS(RootFrameViewport,
                   ScrollableArea,
                   scrollableArea,
                   scrollableArea->isRootFrameViewport(),
                   scrollableArea.isRootFrameViewport());
 
 }  // namespace blink
 
 #endif  // RootFrameViewport_h