Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2454913003: MainFrame scrollbars should work with RFV instead of FV (Closed)
Patch Set: Add TODOs Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 bool scrollbarsCanBeActive() const override; 286 bool scrollbarsCanBeActive() const override;
287 void scrollbarVisibilityChanged() override; 287 void scrollbarVisibilityChanged() override;
288 IntRect scrollableAreaBoundingBox() const override; 288 IntRect scrollableAreaBoundingBox() const override;
289 void registerForAnimation() override; 289 void registerForAnimation() override;
290 void deregisterForAnimation() override; 290 void deregisterForAnimation() override;
291 bool userInputScrollable(ScrollbarOrientation) const override; 291 bool userInputScrollable(ScrollbarOrientation) const override;
292 bool shouldPlaceVerticalScrollbarOnLeft() const override; 292 bool shouldPlaceVerticalScrollbarOnLeft() const override;
293 int pageStep(ScrollbarOrientation) const override; 293 int pageStep(ScrollbarOrientation) const override;
294 ScrollBehavior scrollBehaviorStyle() const override; 294 ScrollBehavior scrollBehaviorStyle() const override;
295 CompositorAnimationTimeline* compositorAnimationTimeline() const override; 295 CompositorAnimationTimeline* compositorAnimationTimeline() const override;
296 void getTickmarks(Vector<IntRect>& rects) const override;
296 297
297 void visibleSizeChanged(); 298 void visibleSizeChanged();
298 299
299 // FIXME: We shouldn't allow access to m_overflowRect outside this class. 300 // FIXME: We shouldn't allow access to m_overflowRect outside this class.
300 LayoutRect overflowRect() const { return m_overflowRect; } 301 LayoutRect overflowRect() const { return m_overflowRect; }
301 302
302 void scrollToAbsolutePosition( 303 void scrollToAbsolutePosition(
303 const FloatPoint& position, 304 const FloatPoint& position,
304 ScrollBehavior scrollBehavior = ScrollBehaviorInstant, 305 ScrollBehavior scrollBehavior = ScrollBehaviorInstant,
305 ScrollType scrollType = ProgrammaticScroll) { 306 ScrollType scrollType = ProgrammaticScroll) {
(...skipping 21 matching lines...) Expand all
327 328
328 bool updateAfterCompositingChange() override; 329 bool updateAfterCompositingChange() override;
329 330
330 bool hasScrollbar() const { 331 bool hasScrollbar() const {
331 return hasHorizontalScrollbar() || hasVerticalScrollbar(); 332 return hasHorizontalScrollbar() || hasVerticalScrollbar();
332 } 333 }
333 bool hasOverflowControls() const { 334 bool hasOverflowControls() const {
334 return hasScrollbar() || scrollCorner() || resizer(); 335 return hasScrollbar() || scrollCorner() || resizer();
335 } 336 }
336 337
338 // TODO(crbug.com/661236): Implement this method by refactoring relevant bits
339 // from updateAfterLayout.
340 void updateScrollbars() override{};
skobes 2016/11/09 23:18:25 This method should just go away right? Once RFV o
ymalik 2016/11/10 17:58:04 Yeah. I added a comment in the parent class and an
341
337 LayoutScrollbarPart* scrollCorner() const override { return m_scrollCorner; } 342 LayoutScrollbarPart* scrollCorner() const override { return m_scrollCorner; }
338 343
339 void resize(const PlatformEvent&, const LayoutSize&); 344 void resize(const PlatformEvent&, const LayoutSize&);
340 IntSize offsetFromResizeCorner(const IntPoint& absolutePoint) const; 345 IntSize offsetFromResizeCorner(const IntPoint& absolutePoint) const;
341 346
342 bool inResizeMode() const { return m_inResizeMode; } 347 bool inResizeMode() const { return m_inResizeMode; }
343 void setInResizeMode(bool inResizeMode) { m_inResizeMode = inResizeMode; } 348 void setInResizeMode(bool inResizeMode) { m_inResizeMode = inResizeMode; }
344 349
345 IntRect touchResizerCornerRect(const IntRect& bounds) const { 350 IntRect touchResizerCornerRect(const IntRect& bounds) const {
346 return resizerCornerRect(bounds, ResizerForTouch); 351 return resizerCornerRect(bounds, ResizerForTouch);
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 589
585 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 590 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
586 ScrollableArea, 591 ScrollableArea,
587 scrollableArea, 592 scrollableArea,
588 scrollableArea->isPaintLayerScrollableArea(), 593 scrollableArea->isPaintLayerScrollableArea(),
589 scrollableArea.isPaintLayerScrollableArea()); 594 scrollableArea.isPaintLayerScrollableArea());
590 595
591 } // namespace blink 596 } // namespace blink
592 597
593 #endif // LayerScrollableArea_h 598 #endif // LayerScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698