Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/frame/RootFrameViewport.cpp

Issue 2454913003: MainFrame scrollbars should work with RFV instead of FV (Closed)
Patch Set: Add TODOs Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/RootFrameViewport.h" 5 #include "core/frame/RootFrameViewport.h"
6 6
7 #include "core/frame/FrameView.h" 7 #include "core/frame/FrameView.h"
8 #include "core/layout/ScrollAlignment.h" 8 #include "core/layout/ScrollAlignment.h"
9 #include "core/layout/ScrollAnchor.h" 9 #include "core/layout/ScrollAnchor.h"
10 #include "platform/geometry/DoubleRect.h" 10 #include "platform/geometry/DoubleRect.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 delta = targetOffset - scrollOffset(); 88 delta = targetOffset - scrollOffset();
89 visualViewport().setScrollOffset(visualViewport().scrollOffset() + delta, 89 visualViewport().setScrollOffset(visualViewport().scrollOffset() + delta,
90 ProgrammaticScroll); 90 ProgrammaticScroll);
91 } 91 }
92 92
93 void RootFrameViewport::didUpdateVisualViewport() { 93 void RootFrameViewport::didUpdateVisualViewport() {
94 if (RuntimeEnabledFeatures::scrollAnchoringEnabled()) { 94 if (RuntimeEnabledFeatures::scrollAnchoringEnabled()) {
95 if (ScrollAnchor* anchor = layoutViewport().scrollAnchor()) 95 if (ScrollAnchor* anchor = layoutViewport().scrollAnchor())
96 anchor->clear(); 96 anchor->clear();
97 } 97 }
98
99 layoutViewport().updateScrollbars();
98 } 100 }
99 101
100 LayoutBox* RootFrameViewport::layoutBox() const { 102 LayoutBox* RootFrameViewport::layoutBox() const {
101 return layoutViewport().layoutBox(); 103 return layoutViewport().layoutBox();
102 } 104 }
103 105
104 FloatQuad RootFrameViewport::localToVisibleContentQuad( 106 FloatQuad RootFrameViewport::localToVisibleContentQuad(
105 const FloatQuad& quad, 107 const FloatQuad& quad,
106 const LayoutObject* localObject, 108 const LayoutObject* localObject,
107 unsigned flags) const { 109 unsigned flags) const {
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 197 }
196 198
197 ScrollOffset clampedOffset = clampScrollOffset(offset); 199 ScrollOffset clampedOffset = clampScrollOffset(offset);
198 ScrollableArea::setScrollOffset(clampedOffset, scrollType, scrollBehavior); 200 ScrollableArea::setScrollOffset(clampedOffset, scrollType, scrollBehavior);
199 } 201 }
200 202
201 ScrollBehavior RootFrameViewport::scrollBehaviorStyle() const { 203 ScrollBehavior RootFrameViewport::scrollBehaviorStyle() const {
202 return layoutViewport().scrollBehaviorStyle(); 204 return layoutViewport().scrollBehaviorStyle();
203 } 205 }
204 206
207 Scrollbar* RootFrameViewport::horizontalScrollbar() const {
208 return layoutViewport().horizontalScrollbar();
209 }
210
211 Scrollbar* RootFrameViewport::verticalScrollbar() const {
212 return layoutViewport().verticalScrollbar();
213 }
214
215 bool RootFrameViewport::hasOverlayScrollbars() const {
216 return layoutViewport().hasOverlayScrollbars();
217 }
218
219 void RootFrameViewport::setScrollbarNeedsPaintInvalidation(
220 ScrollbarOrientation orientation) {
221 return layoutViewport().setScrollbarNeedsPaintInvalidation(orientation);
222 }
223
224 LayoutRect RootFrameViewport::visualRectForScrollbarParts() const {
225 return layoutViewport().visualRectForScrollbarParts();
226 }
227
228 ScrollbarOverlayColorTheme RootFrameViewport::getScrollbarOverlayColorTheme()
229 const {
230 return layoutViewport().getScrollbarOverlayColorTheme();
231 }
232
233 void RootFrameViewport::setTickmarks(const Vector<IntRect>& tickmarks) {
234 m_tickmarks = tickmarks;
235 }
236
237 void RootFrameViewport::getTickmarks(Vector<IntRect>& tickmarks) const {
238 if (!m_tickmarks.isEmpty())
239 tickmarks = m_tickmarks;
240 else
241 layoutViewport().getTickmarks(tickmarks);
242 }
243
244 void RootFrameViewport::mouseEnteredScrollbar(Scrollbar& scrollbar) {
245 layoutViewport().mouseEnteredScrollbar(scrollbar);
246 }
247
248 void RootFrameViewport::mouseExitedScrollbar(Scrollbar& scrollbar) {
249 layoutViewport().mouseExitedScrollbar(scrollbar);
250 }
251
252 void RootFrameViewport::scrollbarVisibilityChanged() {
253 layoutViewport().scrollbarVisibilityChanged();
254 }
255
256 bool RootFrameViewport::scrollbarsHidden() const {
257 return layoutViewport().scrollbarsHidden();
258 }
259
260 IntRect RootFrameViewport::convertFromScrollbarToContainingWidget(
261 const Scrollbar& scrollbar,
262 const IntRect& localRect) const {
263 return layoutViewport().convertFromScrollbarToContainingWidget(scrollbar,
264 localRect);
265 }
266
267 IntRect RootFrameViewport::convertFromContainingWidgetToScrollbar(
268 const Scrollbar& scrollbar,
269 const IntRect& parentRect) const {
270 return layoutViewport().convertFromContainingWidgetToScrollbar(scrollbar,
271 parentRect);
272 }
273
274 IntPoint RootFrameViewport::convertFromScrollbarToContainingWidget(
275 const Scrollbar& scrollbar,
276 const IntPoint& localPoint) const {
277 return layoutViewport().convertFromScrollbarToContainingWidget(scrollbar,
278 localPoint);
279 }
280
281 IntPoint RootFrameViewport::convertFromContainingWidgetToScrollbar(
282 const Scrollbar& scrollbar,
283 const IntPoint& parentPoint) const {
284 return layoutViewport().convertFromContainingWidgetToScrollbar(scrollbar,
285 parentPoint);
286 }
287
288 ScrollOffset RootFrameViewport::scrollAnimatorDesiredTargetOffset() const {
289 return layoutViewport().scrollAnimatorDesiredTargetOffset() +
290 visualViewport().scrollAnimatorDesiredTargetOffset();
291 }
292
293 void RootFrameViewport::setScrollCornerNeedsPaintInvalidation() {
294 return layoutViewport().setScrollCornerNeedsPaintInvalidation();
295 }
296
205 LayoutRect RootFrameViewport::scrollIntoView(const LayoutRect& rectInContent, 297 LayoutRect RootFrameViewport::scrollIntoView(const LayoutRect& rectInContent,
206 const ScrollAlignment& alignX, 298 const ScrollAlignment& alignX,
207 const ScrollAlignment& alignY, 299 const ScrollAlignment& alignY,
208 ScrollType scrollType) { 300 ScrollType scrollType) {
209 // We want to move the rect into the viewport that excludes the scrollbars so 301 // We want to move the rect into the viewport that excludes the scrollbars so
210 // we intersect the visual viewport with the scrollbar-excluded frameView 302 // we intersect the visual viewport with the scrollbar-excluded frameView
211 // content rect. However, we don't use visibleContentRect directly since it 303 // content rect. However, we don't use visibleContentRect directly since it
212 // floors the scroll offset. Instead, we use ScrollAnimatorBase::currentOffset 304 // floors the scroll offset. Instead, we use ScrollAnimatorBase::currentOffset
213 // and construct a LayoutRect from that. 305 // and construct a LayoutRect from that.
214 LayoutRect frameRectInContent = 306 LayoutRect frameRectInContent =
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 visualViewport().clearScrollableArea(); 545 visualViewport().clearScrollableArea();
454 } 546 }
455 547
456 DEFINE_TRACE(RootFrameViewport) { 548 DEFINE_TRACE(RootFrameViewport) {
457 visitor->trace(m_visualViewport); 549 visitor->trace(m_visualViewport);
458 visitor->trace(m_layoutViewport); 550 visitor->trace(m_layoutViewport);
459 ScrollableArea::trace(visitor); 551 ScrollableArea::trace(visitor);
460 } 552 }
461 553
462 } // namespace blink 554 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698