Issue 2454863002: Fix iOS autofill JavaScript compiler warnings.

Issue 2454863002: Fix iOS autofill JavaScript compiler warnings. (Closed)

Created:
4 years, 1 month ago by Justin Donnelly

Modified:
4 years, 1 month ago

Reviewers:
Eugene But (OOO till 7-30)

CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix iOS autofill JavaScript compiler warnings. BUG=642135 Committed: https://crrev.com/da45998ad2904af356dbc545e161a534adcf2034 Cr-Commit-Position: refs/heads/master@{#428019}

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	components/autofill/ios/browser/resources/autofill_controller.js	View		4 chunks	+3 lines, -6 lines	0 comments	Download
	M	ios/web/web_state/js/resources/common.js	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 11 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Justin Donnelly

For reference, here's the warnings that are no longer produced with these changes: [10/1938] ACTION ...

4 years, 1 month ago (2016-10-26 22:02:40 UTC) #3

For reference, here's the warnings that are no longer produced with these
changes:

[10/1938] ACTION
//components/autofill/ios/browser:in..._js_compile_js(//build/toolchain/mac:ios_clang_arm64)
../../components/autofill/ios/browser/resources/autofill_controller.js:602:
WARNING - actual parameter 1 of __gCrWeb.autofill.isAutofillableElement does not
match formal parameter
found   : (Element|null)
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
    if (!__gCrWeb.autofill.isAutofillableElement(element)) {
                                                 ^

../../components/autofill/ios/browser/resources/autofill_controller.js:611:
WARNING - actual parameter 1 of __gCrWeb.autofill.isSelectElement does not match
formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
        !__gCrWeb.autofill.isSelectElement(element) &&
                                           ^

../../components/autofill/ios/browser/resources/autofill_controller.js:621:
WARNING - actual parameter 1 of __gCrWeb.autofill.isTextInput does not match
formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
    if (__gCrWeb.autofill.isTextInput(element) ||
                                      ^

../../components/autofill/ios/browser/resources/autofill_controller.js:622:
WARNING - actual parameter 1 of __gCrWeb.autofill.isTextAreaElement does not
match formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
        __gCrWeb.autofill.isTextAreaElement(element)) {
                                            ^

../../components/autofill/ios/browser/resources/autofill_controller.js:624:
WARNING - actual parameter 1 of __gCrWeb.autofill.isSelectElement does not match
formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
    } else if (__gCrWeb.autofill.isSelectElement(element)) {
                                                 ^

../../components/autofill/ios/browser/resources/autofill_controller.js:634:
WARNING - Function Element.prototype.setAttribute: called with 1 argument(s).
Function requires at least 2 argument(s) and no more than 2 argument(s).
    element.setAttribute('chrome-autofilled');
    ^

../../components/autofill/ios/browser/resources/autofill_controller.js:671:
WARNING - actual parameter 1 of __gCrWeb.autofill.isTextInput does not match
formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
    if (__gCrWeb.autofill.isTextInput(element) ||
                                      ^

../../components/autofill/ios/browser/resources/autofill_controller.js:672:
WARNING - actual parameter 1 of __gCrWeb.autofill.isTextAreaElement does not
match formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
        __gCrWeb.autofill.isTextAreaElement(element)) {
                                            ^

../../components/autofill/ios/browser/resources/autofill_controller.js:674:
WARNING - actual parameter 1 of __gCrWeb.autofill.isSelectElement does not match
formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
    } else if (__gCrWeb.autofill.isSelectElement(element)) {
                                                 ^

../../components/autofill/ios/browser/resources/autofill_controller.js:682:
WARNING - actual parameter 1 of __gCrWeb.autofill.isCheckableElement does not
match formal parameter
found   : Element
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
    } else if (__gCrWeb.autofill.isCheckableElement(element)) {
                                                    ^

../../components/autofill/ios/browser/resources/autofill_controller.js:1040:
WARNING - actual parameter 1 of __gCrWeb.common.isFormControlElement does not
match formal parameter
found   : Node
required: (Element|null)
    if (__gCrWeb.common.isFormControlElement(node)) {
                                             ^

../../components/autofill/ios/browser/resources/autofill_controller.js:2057:
WARNING - actual parameter 1 of __gCrWeb.autofill.isAutofillableElement does not
match formal parameter
found   : (Element|null)
required: (HTMLInputElement|HTMLSelectElement|HTMLTextAreaElement|null)
      if (!__gCrWeb.autofill.isAutofillableElement(element)) {
                                                   ^

0 error(s), 12 warning(s), 81.7% typed

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454863002/1

4 years, 1 month ago (2016-10-27 14:15:46 UTC) #8

commit-bot: I haz the power

4 years, 1 month ago (2016-10-27 14:34:13 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/da45998ad2904af356dbc545e161a534adcf2034
Cr-Commit-Position: refs/heads/master@{#428019}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages