Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2454813004: Make PermissionRequest::GetIconId return different types on desktop and Android so that the IDR_ an… (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Make PermissionRequest::GetIconId return different types on desktop and Android so that the IDR_ and vector id versions don't coexist on any single platform. BUG=651270 Review-Url: https://codereview.chromium.org/2385063005 Cr-Commit-Position: refs/heads/master@{#425577} (cherry picked from commit 20c051a9a415b64187d410d0ec207c0442d784f5) Committed: https://chromium.googlesource.com/chromium/src/+/089cf6d16f3733ff8c78767c56bd8856e6695d09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -105 lines) Patch
D chrome/app/theme/default_100_percent/common/infobar_media_stream_screen_share.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/infobar_warning.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/register_protocol_handler.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/infobar_media_stream_screen_share.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/infobar_warning.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/register_protocol_handler.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/media/media_throttle_infobar_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/resource_id.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_quota_permission_context.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_permission_request.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc View 2 chunks +1 line, -17 lines 0 comments Download
M chrome/browser/download/download_permission_request.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_permission_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc/media_stream_capture_indicator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/permissions/mock_permission_request.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/mock_permission_request.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_request.h View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/permissions/permission_request.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.cc View 3 chunks +1 line, -26 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_update_infobar_delegate_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_prompt_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M components/resources/autofill_scaled_resources.grdp View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/vector_icons/microphone.icon View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 1 month ago (2016-10-27 15:38:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
089cf6d16f3733ff8c78767c56bd8856e6695d09.

Powered by Google App Engine
This is Rietveld 408576698