Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2454783002: [NoStatePrefetch] Re-enable non-html tests (Closed)

Created:
4 years, 1 month ago by pasko
Modified:
4 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NoStatePrefetch] Re-enable non-html tests After the prefetchFinished() notification was moved to Document::finishedParsing(), it actually started executing even for non-HTML documents, which kills the renderer properly, and hence the tests can be re-enabled. Initially prefetchFinished() was called HTMLDocumentParser::end() which made these tests fail, but then the call was moved to the better place during review. BUG=632361, 649632 Committed: https://crrev.com/55713eceac5ddad41cbf6be7b4f4864dffcb8722 Cr-Commit-Position: refs/heads/master@{#428035}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
pasko
PTaL
4 years, 1 month ago (2016-10-26 17:33:13 UTC) #4
droger
lgtm
4 years, 1 month ago (2016-10-27 08:39:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454783002/20001
4 years, 1 month ago (2016-10-27 15:22:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 15:57:40 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:29:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55713eceac5ddad41cbf6be7b4f4864dffcb8722
Cr-Commit-Position: refs/heads/master@{#428035}

Powered by Google App Engine
This is Rietveld 408576698