Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2454773003: Respect ios_app_bundle_id_prefix for ios/web/shell and EarlGrey tests. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Respect ios_app_bundle_id_prefix for ios/web/shell and EarlGrey tests. BUG=613543 Committed: https://crrev.com/b1c17c347cc53041178a0f598a3edb1cef108d44 Cr-Commit-Position: refs/heads/master@{#428335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/config/ios/Host-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M build/config/ios/Module-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M ios/third_party/earl_grey/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M ios/third_party/ochamcrest/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/Info.plist View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
sdefresne
Please take a look and send to CQ if lgty.
4 years, 1 month ago (2016-10-26 18:50:32 UTC) #6
justincohen
LGTM
4 years, 1 month ago (2016-10-27 13:56:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454773003/1
4 years, 1 month ago (2016-10-28 11:21:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 11:40:53 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 11:45:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c17c347cc53041178a0f598a3edb1cef108d44
Cr-Commit-Position: refs/heads/master@{#428335}

Powered by Google App Engine
This is Rietveld 408576698