Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2454763002: Move when swapping, if possible. (Closed)

Created:
4 years, 1 month ago by bungeman-skia
Modified:
4 years, 1 month ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move when swapping, if possible. This change was avoided in the past because vc++ 2013 (12.0) did not properly create default move constructors and move assignment operators. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2454763002 TBR=reed Verbal lgtm Committed: https://skia.googlesource.com/skia/+/6f4293af6906721f09a12818ff3adc767badb3c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M include/core/SkTypes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkTSort.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
bungeman-skia
4 years, 1 month ago (2016-10-26 18:03:39 UTC) #8
mtklein_C
lgtm
4 years, 1 month ago (2016-10-26 18:20:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454763002/1
4 years, 1 month ago (2016-10-26 19:10:33 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 19:11:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6f4293af6906721f09a12818ff3adc767badb3c7

Powered by Google App Engine
This is Rietveld 408576698