Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: tools/perf/benchmarks/canvasmark.py

Issue 245473002: Get rid of page_set.FromDict from browsermark, canvasmark, dom_perf, html5gaming benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/browsermark.py ('k') | tools/perf/benchmarks/dom_perf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/canvasmark.py
diff --git a/tools/perf/benchmarks/canvasmark.py b/tools/perf/benchmarks/canvasmark.py
index 56f30182908446a83369a88859823f9611a55ffb..f84610180eaba54bf88fe1ba55aabfd5891e8001 100644
--- a/tools/perf/benchmarks/canvasmark.py
+++ b/tools/perf/benchmarks/canvasmark.py
@@ -15,6 +15,7 @@ from telemetry import test
from telemetry.page import page_measurement
from telemetry.page import page_set
+
class _CanvasMarkMeasurement(page_measurement.PageMeasurement):
def WillNavigateToPage(self, page, tab):
@@ -49,12 +50,10 @@ class CanvasMark(test.Test):
test = _CanvasMarkMeasurement
def CreatePageSet(self, options):
- return page_set.PageSet.FromDict({
- 'archive_data_file': '../page_sets/data/canvasmark.json',
- 'make_javascript_deterministic': False,
- 'pages': [
- { 'url':
- 'http://www.kevs3d.co.uk/dev/canvasmark/?auto=true'}
- ]
- }, os.path.abspath(__file__))
-
+ ps = page_set.PageSet(
+ file_path=os.path.abspath(__file__),
+ archive_data_file='../page_sets/data/canvasmark.json',
+ make_javascript_deterministic=False)
+ ps.AddPageWithDefaultRunNavigate(
+ 'http://www.kevs3d.co.uk/dev/canvasmark/?auto=true')
+ return ps
« no previous file with comments | « tools/perf/benchmarks/browsermark.py ('k') | tools/perf/benchmarks/dom_perf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698