Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2454713003: [promises] Remove PromiseRejectEvent (Closed)

Created:
4 years, 1 month ago by gsathya
Modified:
4 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Remove PromiseRejectEvent This is no longer used. BUG=v8:5343 Committed: https://crrev.com/b4f76a8ee81f6b3055f94dcaad870d148d487323 Cr-Commit-Position: refs/heads/master@{#40622}

Patch Set 1 #

Patch Set 2 : remove from header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M src/runtime/runtime.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-promise.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
gsathya
I missed this in my previous patch
4 years, 1 month ago (2016-10-27 12:35:01 UTC) #8
adamk
lgtm
4 years, 1 month ago (2016-10-27 12:36:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454713003/20001
4 years, 1 month ago (2016-10-27 13:03:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 13:04:46 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:35 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4f76a8ee81f6b3055f94dcaad870d148d487323
Cr-Commit-Position: refs/heads/master@{#40622}

Powered by Google App Engine
This is Rietveld 408576698