Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2454703004: GN: Format more gn files (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -76 lines) Patch
M build/config/android/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/arm.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/mac/mac_sdk.gni View 1 chunk +4 lines, -1 line 0 comments Download
M build/config/mac/rules.gni View 13 chunks +29 lines, -29 lines 0 comments Download
M build/config/templates/templates.gni View 2 chunks +12 lines, -9 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/rules.gni View 1 chunk +10 lines, -5 lines 0 comments Download
M utils/create_timestamp.gni View 1 chunk +9 lines, -6 lines 0 comments Download
M utils/dartdevc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M utils/invoke_dart.gni View 3 chunks +16 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 1 month ago (2016-10-27 11:23:32 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-10-27 11:24:28 UTC) #3
zra
4 years, 1 month ago (2016-10-27 11:25:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8169499ef8b4e11a6a465ab3a77da3db21818081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698