third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2454693003: adjustedPositionRelativeTo() couldn't find offsetParent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2454693003: adjustedPositionRelativeTo() couldn't find offsetParent. (Closed)

Patch Set: Update comment, since the problem described has been fixed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 0d07b008fa00024dadfa534d5ffdd185eeed2c8b..4f9e99ebc6385f9f6ad27c6572ccc48714c81f17 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -1000,12 +1000,13 @@ LayoutPoint LayoutBoxModelObject::adjustedPositionRelativeTo(

// Note that we may fail to find |offsetParent| while walking the

// container chain, if |offsetParent| is an inline split into

- // continuations: <body style="display:inline;" id="offsetParent"><div>

- // </div><span id="this">

+ // continuations: <body style="display:inline;" id="offsetParent">

+ // <div id="this">

// This is why we have to do a nullptr check here.

// offset(Left|Top) is generally broken when offsetParent is inline.

for (const LayoutObject* current = container();

- current && current != offsetParent; current = current->container()) {

+ current && current->node() != element;

+ current = current->container()) {

// FIXME: What are we supposed to do inside SVG content?

referencePoint.move(current->columnOffset(referencePoint));

if (current->isBox() && !current->isTableRow())

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/inline/inline-offsetLeft-continuation-expected.txt ('k') | no next file » | no next file with comments »