Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2454693002: Revert of [heap] Uncommit marking deque in concurrent task. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Uncommit marking deque in concurrent task. (patchset #7 id:120001 of https://codereview.chromium.org/2442443003/ ) Reason for revert: Seems to break the world, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/14118 Original issue's description: > [heap] Uncommit marking deque in concurrent task. > > BUG= TBR=mlippautz@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/35e4a03f5b4f8dadd900b1eb118f028bb5dfe6ec Cr-Commit-Position: refs/heads/master@{#40588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -83 lines) Patch
M src/heap/mark-compact.h View 5 chunks +2 lines, -47 lines 0 comments Download
M src/heap/mark-compact.cc View 5 chunks +3 lines, -35 lines 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Uncommit marking deque in concurrent task.
4 years, 1 month ago (2016-10-26 12:39:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454693002/1
4 years, 1 month ago (2016-10-26 12:39:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 12:39:19 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:13:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35e4a03f5b4f8dadd900b1eb118f028bb5dfe6ec
Cr-Commit-Position: refs/heads/master@{#40588}

Powered by Google App Engine
This is Rietveld 408576698