Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 2454673002: Add missing return statement to CheckReturnValue's copy assignment operator. (Closed)

Created:
4 years, 1 month ago by grt (UTC plus 2)
Modified:
4 years ago
Reviewers:
huangs
CC:
chromium-reviews, wfh+watch_chromium.org, huangs+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing return statement to CheckReturnValue's copy assignment operator. BUG=none R=huangs@chromium.org Committed: https://crrev.com/475681390eea963b4bbba2308d7aff4383254904 Cr-Commit-Position: refs/heads/master@{#433896}

Patch Set 1 #

Patch Set 2 : sync to position 433806 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M courgette/memory_allocator.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
grt (UTC plus 2)
4 years, 1 month ago (2016-10-26 11:38:39 UTC) #1
grt (UTC plus 2)
Please check the CQ box if this looks good to you. Thanks.
4 years, 1 month ago (2016-10-26 11:41:55 UTC) #4
grt (UTC plus 2)
huangs: ping! please check the cq box if it looks good to you. thanks.
4 years ago (2016-11-22 07:37:27 UTC) #9
huangs
Really sorry, didn't see this! LGTM. Interesting that unused template functions with missing return value ...
4 years ago (2016-11-22 17:12:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454673002/20001
4 years ago (2016-11-22 17:13:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-22 17:17:23 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-22 17:23:41 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/475681390eea963b4bbba2308d7aff4383254904
Cr-Commit-Position: refs/heads/master@{#433896}

Powered by Google App Engine
This is Rietveld 408576698