Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 24546003: Revert 3.20 branch to 3.20.17.7 (Closed)

Created:
7 years, 2 months ago by Jakob Kummerow
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert 3.20 branch to 3.20.17.7 Committed: http://code.google.com/p/v8/source/detail?r=16950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -500 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +4 lines, -59 lines 0 comments Download
M src/hydrogen-instructions.cc View 4 chunks +21 lines, -184 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +1 line, -1 line 0 comments Download
M src/objects-inl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/property.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M test/mjsunit/allocation-folding.js View 2 chunks +2 lines, -25 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-285355.js View 1 chunk +0 lines, -43 lines 0 comments Download
D test/mjsunit/regress/regress-regexp-construct-result.js View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
LGTM
7 years, 2 months ago (2013-09-25 19:35:51 UTC) #1
Jakob Kummerow
Committed patchset #1 manually as r16950 (presubmit successful).
7 years, 2 months ago (2013-09-25 19:38:48 UTC) #2
tjfontaine
On 2013/09/25 19:38:48, Jakob wrote: > Committed patchset #1 manually as r16950 (presubmit successful). FWIW ...
7 years, 2 months ago (2013-09-25 20:20:52 UTC) #3
Jakob Kummerow
We want to get all the reverted patches back into the branch, as soon as ...
7 years, 2 months ago (2013-09-25 20:26:39 UTC) #4
tjfontaine
7 years, 2 months ago (2013-09-25 20:32:55 UTC) #5
Message was sent while issue was closed.
On 2013/09/25 20:26:39, Jakob wrote:
> We want to get all the reverted patches back into the branch, as soon as we
> figure out what caused the crashes we were seeing in Chrome.
> 
> Do you happen to have a repro case for the issues you were seeing?

https://github.com/joyent/node/issues/6214#issuecomment-24464837 is the test
case we hit it with on node on osx, but it's not particularly standalone for
something like d8. More or less lots of fast GC pressure being created in an
array -- I will try and slim it down further for you.

I have so far only been able to reliably hit this on OSX, not on sunos/smartos

Powered by Google App Engine
This is Rietveld 408576698