Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2454593002: Add new fields for Purge+Suspend to WebContentsData. (Closed)

Created:
4 years, 1 month ago by tasak
Modified:
4 years, 1 month ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new fields for Purge+Suspend to WebContentsData. - intent-to-implement-and-ship of background renderer's purge + suspend is https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 - one of the documents attached in the above intent is https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing - The feature is not enabled by default because purge-and-suspend-time is 0. BUG=635419 Committed: https://crrev.com/498b24642cfb7c8dd84ca60c65c684dbf3f60bbf Cr-Commit-Position: refs/heads/master@{#427935}

Patch Set 1 #

Patch Set 2 : Add TabManagerWebContentsDataTest.PurgeAndSuspendState. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3 lines) Patch
M chrome/browser/memory/tab_manager.h View 1 2 chunks +26 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager_web_contents_data.h View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/memory/tab_manager_web_contents_data.cc View 2 chunks +21 lines, -1 line 0 comments Download
M chrome/browser/memory/tab_manager_web_contents_data_unittest.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tasak
Would you review this CL? I created this CL from https://codereview.chromium.org/2387603003
4 years, 1 month ago (2016-10-26 07:07:42 UTC) #4
haraken
Can we add test for WebContentsData?
4 years, 1 month ago (2016-10-26 07:16:37 UTC) #5
tasak
On 2016/10/26 07:16:37, haraken wrote: > Can we add test for WebContentsData? Sure. Done.
4 years, 1 month ago (2016-10-26 07:49:58 UTC) #7
haraken
LGTM
4 years, 1 month ago (2016-10-26 07:50:15 UTC) #9
chrisha
also lgtm
4 years, 1 month ago (2016-10-26 21:27:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454593002/20001
4 years, 1 month ago (2016-10-27 04:11:16 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 04:16:26 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 04:17:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/498b24642cfb7c8dd84ca60c65c684dbf3f60bbf
Cr-Commit-Position: refs/heads/master@{#427935}

Powered by Google App Engine
This is Rietveld 408576698