Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2454573002: Convert editing/execCommand/nsresponder-indent.html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/nsresponder-indent.html to utilize w3c test harness This patch converts "nsresponder-indent.html" to utilize w3c test harness with |assert_selection()| to simplify test case for improving code health. This patch is a preparation of http://crrev.com/1958093002 BUG=625533 TEST=n/a; no behavior changes Committed: https://crrev.com/76e037622f8f4c308e584a530da0af572a962b61 Cr-Commit-Position: refs/heads/master@{#427645}

Patch Set 1 : 2016-10-26T15:20:19 #

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years, 1 month ago (2016-10-26 07:53:44 UTC) #8
Xiaocheng
lgtm What does NSResponder stand for?
4 years, 1 month ago (2016-10-26 08:59:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454573002/1
4 years, 1 month ago (2016-10-26 09:02:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 09:08:16 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:09:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76e037622f8f4c308e584a530da0af572a962b61
Cr-Commit-Position: refs/heads/master@{#427645}

Powered by Google App Engine
This is Rietveld 408576698