chrome/browser/extensions/chrome_content_browser_client_extensions_part.h - Issue 2454563003: Fix web accessible resource checks in ShouldAllowOpenURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

Issue 2454563003: Fix web accessible resource checks in ShouldAllowOpenURL (Closed)

Patch Set: Round 2 of Devlin's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

index a9a23332357e28e61f5472875d3d5c6ebed49de2..8b8617b4711ed61dd818aea0bf651e886bb41938 100644

--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

@@ -56,7 +56,6 @@ class ChromeContentBrowserClientExtensionsPart

// Similiar to ChromeContentBrowserClient::ShouldAllowOpenURL(), but the

// return value indicates whether to use |result| or not.

static bool ShouldAllowOpenURL(content::SiteInstance* site_instance,

- const GURL& from_url,

const GURL& to_url,

bool* result);