Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(163)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/uitest/window_open/manifest.json
Issue
2454563003
:
Fix web accessible resource checks in ShouldAllowOpenURL (Closed)
Patch Set: Round 2 of Devlin's comments
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/chrome_content_browser_client.cc
chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
chrome/browser/extensions/extension_resource_request_policy_apitest.cc
chrome/browser/extensions/process_manager_browsertest.cc
chrome/browser/extensions/window_open_apitest.cc
chrome/test/data/extensions/uitest/window_open/manifest.json
content/browser/frame_host/navigator_impl.cc
tools/metrics/histograms/histograms.xml
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/extensions/window_open_apitest.cc
('k') |
content/browser/frame_host/navigator_impl.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {
1 {
2 "version": "1.0.0.0",
2 "version": "1.0.0.0",
3 "manifest_version": 2,
3 "manifest_version": 2,
4 "name": "window.open test",
4 "name": "window.open test",
5 "description": "An extension for an extension UITest.",
5 "description": "An extension for an extension UITest.",
6
"permissions": ["tabs"]
6
"permissions": ["tabs"]
,
7
"web_accessible_resources": ["newtab.html"]
7 }
8 }
OLD
NEW
« no previous file with comments
|
« chrome/browser/extensions/window_open_apitest.cc
('k') |
content/browser/frame_host/navigator_impl.cc »
('j') |
no next file with comments »
Issue 2454563003: Fix web accessible resource checks in ShouldAllowOpenURL (Closed)
Created 4 years, 1 month ago by alexmos
Modified 4 years, 1 month ago
Reviewers: ncarter (slow), Charlie Reis, Devlin, Alexei Svitkine (slow)
Base URL:
Comments: 52
This is Rietveld
408576698
Chromium Code Reviews
Issue 2454563003:
Fix web accessible resource checks in ShouldAllowOpenURL (Closed)
