Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

Issue 2454563003: Fix web accessible resource checks in ShouldAllowOpenURL (Closed)
Patch Set: Charlie's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_
6 #define CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_ 6 #define CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "chrome/browser/chrome_content_browser_client_parts.h" 10 #include "chrome/browser/chrome_content_browser_client_parts.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 const GURL& new_url); 49 const GURL& new_url);
50 static bool AllowServiceWorker(const GURL& scope, 50 static bool AllowServiceWorker(const GURL& scope,
51 const GURL& first_party_url, 51 const GURL& first_party_url,
52 content::ResourceContext* context, 52 content::ResourceContext* context,
53 int render_process_id, 53 int render_process_id,
54 int render_frame_id); 54 int render_frame_id);
55 55
56 // Similiar to ChromeContentBrowserClient::ShouldAllowOpenURL(), but the 56 // Similiar to ChromeContentBrowserClient::ShouldAllowOpenURL(), but the
57 // return value indicates whether to use |result| or not. 57 // return value indicates whether to use |result| or not.
58 static bool ShouldAllowOpenURL(content::SiteInstance* site_instance, 58 static bool ShouldAllowOpenURL(content::SiteInstance* site_instance,
59 const GURL& from_url,
60 const GURL& to_url, 59 const GURL& to_url,
61 bool* result); 60 bool* result);
62 61
63 // Helper function to call InfoMap::SetSigninProcess(). 62 // Helper function to call InfoMap::SetSigninProcess().
64 static void SetSigninProcess(content::SiteInstance* site_instance); 63 static void SetSigninProcess(content::SiteInstance* site_instance);
65 64
66 // Creates a new VpnServiceProxy. The caller owns the returned value. It's 65 // Creates a new VpnServiceProxy. The caller owns the returned value. It's
67 // valid to return nullptr. 66 // valid to return nullptr.
68 static std::unique_ptr<content::VpnServiceProxy> GetVpnServiceProxy( 67 static std::unique_ptr<content::VpnServiceProxy> GetVpnServiceProxy(
69 content::BrowserContext* browser_context); 68 content::BrowserContext* browser_context);
(...skipping 20 matching lines...) Expand all
90 Profile* profile) override; 89 Profile* profile) override;
91 void ResourceDispatcherHostCreated() override; 90 void ResourceDispatcherHostCreated() override;
92 91
93 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClientExtensionsPart); 92 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClientExtensionsPart);
94 }; 93 };
95 94
96 } // namespace extensions 95 } // namespace extensions
97 96
98 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PA RT_H_ 97 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PA RT_H_
99 98
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698