chrome/test/data/extensions/uitest/window_open/manifest.json - Issue 2454563003: Fix web accessible resource checks in ShouldAllowOpenURL

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/uitest/window_open/manifest.json

Issue 2454563003: Fix web accessible resource checks in ShouldAllowOpenURL (Closed)

Patch Set: Tighten check a bit more Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "version": "1.0.0.0",	2 "version": "1.0.0.0",

3 "manifest_version": 2,	3 "manifest_version": 2,

4 "name": "window.open test",	4 "name": "window.open test",

5 "description": "An extension for an extension UITest.",	5 "description": "An extension for an extension UITest.",

6 "permissions": ["tabs"]	6 "permissions": ["tabs"],

	7 "web_accessible_resources": ["newtab.html"]
	alexmos 2016/10/28 00:29:42 Necessary to fix ExtensionBrowserTest.WindowOpenNo Necessary to fix ExtensionBrowserTest.WindowOpenNoPrivileges, which does a window.open on newtab.html and expects it to work.
7 }	8 }

OLD	NEW