Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2454543002: Correct the initial value of CSS independent transform properties (Closed)

Created:
4 years, 1 month ago by trchen
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct the initial value of CSS independent transform properties According to the spec[1], the initial value of translate, scale, and rotate should be 'none', which doesn't force stacking context unlike identity matrix. This CL also make sure the constructor always initialize these properties to initial value. [1] https://drafts.csswg.org/css-transforms-2/#individual-transforms BUG=659434 Committed: https://crrev.com/a022d98375b213ad9f497f220d0b64d6ed77cbc9 Cr-Commit-Position: refs/heads/master@{#427941}

Patch Set 1 #

Patch Set 2 : reduce test #

Total comments: 1

Patch Set 3 : revised #

Patch Set 4 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/transforms/independent-transform-initial-value.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/transforms/independent-transform-initial-value-expected.html View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleTransformData.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 30 (20 generated)
trchen
4 years, 1 month ago (2016-10-26 01:19:07 UTC) #2
alancutter (OOO until 2018)
lgtm after changes. Please add a link to the spec in the description and a ...
4 years, 1 month ago (2016-10-26 01:39:39 UTC) #5
trchen
On 2016/10/26 01:39:39, alancutter wrote: > lgtm after changes. > > Please add a link ...
4 years, 1 month ago (2016-10-26 01:54:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454543002/40001
4 years, 1 month ago (2016-10-26 01:55:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/289480)
4 years, 1 month ago (2016-10-26 02:03:35 UTC) #12
trchen
Sorry Alan I thought you are an owner of Source/core. orz +cc dstockwell
4 years, 1 month ago (2016-10-26 02:49:49 UTC) #14
dstockwell
lgtm
4 years, 1 month ago (2016-10-27 04:31:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454543002/60001
4 years, 1 month ago (2016-10-27 04:35:54 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-27 04:39:57 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 04:41:51 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a022d98375b213ad9f497f220d0b64d6ed77cbc9
Cr-Commit-Position: refs/heads/master@{#427941}

Powered by Google App Engine
This is Rietveld 408576698