Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2454513002:
Use the generated checks for whether origin trials are enabled. (Closed)
|
Created:
4 years, 1 month ago by Sam McNally Modified:
4 years, 1 month ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, Matt Giuca, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse the generated checks for whether origin trials are enabled.
BUG=635741
Committed: https://crrev.com/3a5a4c96d03ff39adaed79d3fa0af80587e091c1
Cr-Commit-Position: refs/heads/master@{#427602}
Patch Set 1 : #
Messages
Total messages: 20 (15 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Use the generated check for the webshare origin trial being enabled. BUG=635741 ========== to ========== Use the generated checks for whether origin trials are enabled. BUG=635741 ==========
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use the generated checks for whether origin trials are enabled. BUG=635741 ========== to ========== Use the generated checks for whether origin trials are enabled. BUG=635741 ==========
sammc@chromium.org changed reviewers: + haraken@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use the generated checks for whether origin trials are enabled. BUG=635741 ========== to ========== Use the generated checks for whether origin trials are enabled. BUG=635741 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use the generated checks for whether origin trials are enabled. BUG=635741 ========== to ========== Use the generated checks for whether origin trials are enabled. BUG=635741 Committed: https://crrev.com/3a5a4c96d03ff39adaed79d3fa0af80587e091c1 Cr-Commit-Position: refs/heads/master@{#427602} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3a5a4c96d03ff39adaed79d3fa0af80587e091c1 Cr-Commit-Position: refs/heads/master@{#427602} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
