Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 24545002: Remove obsolete global SubString method. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger
Modified:
7 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Remove obsolete global SubString method. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M src/handles.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 2 months ago (2013-09-25 09:26:10 UTC) #1
Yang
On 2013/09/25 09:26:10, Michael Starzinger wrote: lgtm.
7 years, 2 months ago (2013-09-25 09:28:12 UTC) #2
Michael Starzinger
7 years, 2 months ago (2013-09-25 09:31:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698