Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2454483002: Make search engine iron-list aware of the global scrollTarget. (Closed)

Created:
4 years, 1 month ago by hcarmona
Modified:
4 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make search engine iron-list aware of the global scrollTarget. This allows virtual scrolling which fixes the issue where only 500 items are displayed in the list. BUG=659323 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a88d285f8f51ecc9425f1f3947706ed99de07af9 Cr-Commit-Position: refs/heads/master@{#428417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_list.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_list.js View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
hcarmona
This was the other section I mentioned in the other CL. This fixes a similar ...
4 years, 1 month ago (2016-10-26 14:06:52 UTC) #7
stevenjb
lgtm
4 years, 1 month ago (2016-10-26 16:27:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454483002/1
4 years, 1 month ago (2016-10-27 05:44:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/56595)
4 years, 1 month ago (2016-10-27 07:04:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454483002/1
4 years, 1 month ago (2016-10-28 17:48:28 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:55:17 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 18:07:37 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a88d285f8f51ecc9425f1f3947706ed99de07af9
Cr-Commit-Position: refs/heads/master@{#428417}

Powered by Google App Engine
This is Rietveld 408576698