Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2454433003: Add MSA optimized I422AlphaToARGBRow_MSA and I422ToRGB24Row_MSA functions (Closed)

Created:
4 years, 1 month ago by manojkumar.bhosale
Modified:
4 years, 1 month ago
CC:
gordana.cmiljanovic_imgtec.com, raghu.gandham_imgtec.com, parag.salasakar_imgtec.com, mandar.sahastrabuddhe_imgtec.com, rob.isherwood_imgtec.com
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add MSA optimized I422AlphaToARGBRow_MSA and I422ToRGB24Row_MSA functions R=fbarchard@google.com BUG=libyuv:634 Performance Gain (vs C vectorized) I422AlphaToARGBRow_MSA : ~1.4x I422AlphaToARGBRow_Any_MSA : ~1.4x I422ToRGB24Row_MSA : ~4.8x I422ToRGB24Row_Any_MSA : ~4.8x Performance Gain (vs C non-vectorized) I422AlphaToARGBRow_MSA : ~7.0x I422AlphaToARGBRow_Any_MSA : ~7.0x I422ToRGB24Row_MSA : ~7.9x I422ToRGB24Row_Any_MSA : ~7.7x Committed: https://chromium.googlesource.com/libyuv/libyuv/+/532f5708a95b02185db463a481c0315524742dd8

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -76 lines) Patch
M include/libyuv/row.h View 3 chunks +28 lines, -0 lines 0 comments Download
M source/convert_argb.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M source/convert_from.cc View 1 chunk +8 lines, -0 lines 1 comment Download
M source/row_any.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M source/row_msa.cc View 6 chunks +168 lines, -76 lines 3 comments Download

Messages

Total messages: 7 (3 generated)
manojkumar.bhosale
4 years, 1 month ago (2016-10-26 06:42:15 UTC) #1
manojkumar.bhosale
Updated with reviewers, cc list and performance gain numbers
4 years, 1 month ago (2016-10-26 06:46:46 UTC) #4
fbarchard1
lgtm just nits about names and indent https://codereview.chromium.org/2454433003/diff/1/source/convert_from.cc File source/convert_from.cc (right): https://codereview.chromium.org/2454433003/diff/1/source/convert_from.cc#newcode563 source/convert_from.cc:563: I422ToRGB24Row = ...
4 years, 1 month ago (2016-10-26 17:56:31 UTC) #5
fbarchard1
4 years, 1 month ago (2016-10-26 18:12:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
532f5708a95b02185db463a481c0315524742dd8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698