Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2351)

Unified Diff: third_party/WebKit/Source/web/SuspendableScriptExecutor.h

Issue 2454433002: [Extensions + Blink] Account for user gesture in v8 function calls (Closed)
Patch Set: more comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/SuspendableScriptExecutor.h
diff --git a/third_party/WebKit/Source/web/SuspendableScriptExecutor.h b/third_party/WebKit/Source/web/SuspendableScriptExecutor.h
index 684318ad72d72e11dc415e393406175c0ffb0e2c..5b9ae983fb45175d5258d57abba1d80e5ea032f0 100644
--- a/third_party/WebKit/Source/web/SuspendableScriptExecutor.h
+++ b/third_party/WebKit/Source/web/SuspendableScriptExecutor.h
@@ -15,6 +15,7 @@ namespace blink {
class LocalFrame;
class ScriptSourceCode;
+class ScriptState;
class WebScriptExecutionCallback;
class SuspendableScriptExecutor final
@@ -48,6 +49,7 @@ class SuspendableScriptExecutor final
virtual ~Executor() {}
virtual Vector<v8::Local<v8::Value>> execute(LocalFrame*) = 0;
+ virtual ScriptState* getScriptState(LocalFrame*) = 0;
DEFINE_INLINE_VIRTUAL_TRACE(){};
};
@@ -63,6 +65,8 @@ class SuspendableScriptExecutor final
void executeAndDestroySelf();
void dispose();
+ // TODO(devlin): m_frame is likely redundant with context accessor on
+ // SuspendableTimer.
Member<LocalFrame> m_frame;
WebScriptExecutionCallback* m_callback;

Powered by Google App Engine
This is Rietveld 408576698