Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 245443005: Move IPC::MessageFilter and router to a separate file (Closed)

Created:
6 years, 8 months ago by dmichael (off chromium)
Modified:
6 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move IPC::MessageFilter and router to a separate file There are no changes in implementation in this CL. This is in preparation for making IPC::Channel support filters on the Channel's thread. BUG=364241 TBR=cpu@chromium.org,nduca@chromium.org cpu: OWNERS for win8 nduca: OWNERS for components/tracing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266057

Patch Set 1 #

Patch Set 2 : small cleanup #

Total comments: 4

Patch Set 3 : Review comments #

Patch Set 4 : Oops, add ipc_message_filter_router.h/cc #

Total comments: 2

Patch Set 5 : pre-review cleanups #

Total comments: 3

Patch Set 6 : review comments #

Patch Set 7 : Add missing include of ipc_message_macros.h #

Patch Set 8 : merge #

Patch Set 9 : Merge + fixes for win and android #

Patch Set 10 : fix gn build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -322 lines) Patch
M chrome/browser/extensions/api/webstore/webstore_api.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_ipc_dispatcher.h View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/media/mock_webrtc_logging_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.h View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M components/nacl/renderer/pnacl_translation_resource_host.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_histogram_message_filter.h View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M content/child/child_histogram_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/child/child_message_filter.h View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M content/child/child_message_filter.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/child_resource_message_filter.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/child_thread.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/db_message_filter.h View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.h View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M content/child/power_monitor_broadcast_source.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/child/power_monitor_broadcast_source.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/power_monitor_broadcast_source_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/quota_message_filter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/common/child_process_host_impl.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/common/font_cache_dispatcher_win.h View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -4 lines 0 comments Download
M content/common/font_cache_dispatcher_win.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_channel.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 1 2 3 chunks +11 lines, -7 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M content/public/common/child_process_host.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/public/renderer/render_thread.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.h View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/dom_storage/dom_storage_dispatcher.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter.h View 1 2 3 4 5 3 chunks +13 lines, -6 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/android/renderer_demuxer_android.h View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/media/android/renderer_demuxer_android.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.h View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/audio_message_filter.h View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_message_filter.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc.gypi View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 1 2 4 chunks +3 lines, -50 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 2 3 4 5 6 1 chunk +4 lines, -119 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_forwarding_message_filter.h View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M ipc/ipc_forwarding_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A ipc/message_filter.h View 1 2 3 4 5 1 chunk +67 lines, -0 lines 0 comments Download
A ipc/message_filter.cc View 1 2 3 4 5 1 chunk +35 lines, -0 lines 0 comments Download
A ipc/message_filter_router.h View 1 2 3 4 5 1 chunk +42 lines, -0 lines 0 comments Download
A ipc/message_filter_router.cc View 1 2 3 4 5 1 chunk +92 lines, -0 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_message_filter.h View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -2 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
dmichael (off chromium)
6 years, 8 months ago (2014-04-21 21:38:26 UTC) #1
jam
https://codereview.chromium.org/245443005/diff/20001/ipc/ipc_channel_proxy.h File ipc/ipc_channel_proxy.h (right): https://codereview.chromium.org/245443005/diff/20001/ipc/ipc_channel_proxy.h#newcode65 ipc/ipc_channel_proxy.h:65: typedef IPC::MessageFilter MessageFilter; i see only 56 files matching ...
6 years, 8 months ago (2014-04-22 17:14:26 UTC) #2
dmichael (off chromium)
https://codereview.chromium.org/245443005/diff/20001/ipc/ipc_channel_proxy.h File ipc/ipc_channel_proxy.h (right): https://codereview.chromium.org/245443005/diff/20001/ipc/ipc_channel_proxy.h#newcode65 ipc/ipc_channel_proxy.h:65: typedef IPC::MessageFilter MessageFilter; On 2014/04/22 17:14:27, jam wrote: > ...
6 years, 8 months ago (2014-04-23 19:42:30 UTC) #3
jam
lgtm https://codereview.chromium.org/245443005/diff/80001/ipc/ipc_message_filter.h File ipc/ipc_message_filter.h (right): https://codereview.chromium.org/245443005/diff/80001/ipc/ipc_message_filter.h#newcode1 ipc/ipc_message_filter.h:1: // Copyright (c) 2014 The Chromium Authors. All ...
6 years, 8 months ago (2014-04-23 21:49:24 UTC) #4
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-23 22:19:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/245443005/100001
6 years, 8 months ago (2014-04-23 22:19:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 22:40:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-23 22:40:58 UTC) #8
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-23 22:58:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/245443005/140001
6 years, 8 months ago (2014-04-23 22:58:30 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 23:20:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 8 months ago (2014-04-23 23:20:36 UTC) #12
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-24 15:37:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/245443005/180001
6 years, 8 months ago (2014-04-24 15:38:03 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:40:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-24 16:40:17 UTC) #16
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-24 16:43:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/245443005/180001
6 years, 8 months ago (2014-04-24 16:44:07 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 21:07:16 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 21:07:17 UTC) #20
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-24 21:13:54 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/245443005/180001
6 years, 8 months ago (2014-04-24 21:34:17 UTC) #22
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 00:07:39 UTC) #23
Message was sent while issue was closed. 
Change committed as 266057

Powered by Google App Engine
This is Rietveld 408576698