Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 245443004: Set the override redirect in browser_tests on aura/x11 (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Alexander Alekseev
Visibility:
Public.

Description

Set the override redirect in browser_tests on aura/x11 BUG=365407 R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265764

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/public/test/browser_test_base.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
oshima
6 years, 8 months ago (2014-04-21 20:27:13 UTC) #1
oshima
derat@ -> primary reviewer jcivelli@ -> owners alemate@ -> fyi
6 years, 8 months ago (2014-04-21 20:29:24 UTC) #2
Daniel Erat
lgtm
6 years, 8 months ago (2014-04-21 21:22:30 UTC) #3
oshima
On 2014/04/21 21:22:30, Daniel Erat wrote: > lgtm jay -> ping?
6 years, 8 months ago (2014-04-23 00:52:13 UTC) #4
oshima
phajdan.jr@, can you review this?
6 years, 8 months ago (2014-04-23 05:58:56 UTC) #5
Paweł Hajdan Jr.
LGTM
6 years, 8 months ago (2014-04-23 10:44:08 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-23 16:40:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/245443004/20001
6 years, 8 months ago (2014-04-23 16:40:51 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 17:24:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-23 17:24:25 UTC) #10
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-23 17:35:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/245443004/20001
6 years, 8 months ago (2014-04-23 17:35:45 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 17:55:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-23 17:55:39 UTC) #14
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-23 22:04:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/245443004/20001
6 years, 8 months ago (2014-04-23 22:05:19 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 23:10:44 UTC) #17
Message was sent while issue was closed. 
Change committed as 265764

Powered by Google App Engine
This is Rietveld 408576698