Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 245443002: Tentatively enable HTMLImports flag to ensure its ship-ability. (Closed)

Created:
6 years, 8 months ago by Hajime Morrita
Modified:
6 years, 8 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews
Visibility:
Public.

Description

Tentatively enable HTMLImports flag to ensure its ship-ability. TEST=none R=dglazkov,esprehn BUG=240592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Hajime Morrita
Rubberstamp please?
6 years, 8 months ago (2014-04-21 17:51:54 UTC) #1
esprehn
Did you send an intent to ship yet? Is there agreement about the spec? I ...
6 years, 8 months ago (2014-04-21 17:56:33 UTC) #2
Hajime Morrita
I thought we can turn the flag on to see the stability, then send intent ...
6 years, 8 months ago (2014-04-21 18:38:40 UTC) #3
dglazkov
On 2014/04/21 18:38:40, morrita1 wrote: > I thought we can turn the flag on to ...
6 years, 8 months ago (2014-04-21 19:01:46 UTC) #4
esprehn
On 2014/04/21 19:01:46, dglazkov wrote: > On 2014/04/21 18:38:40, morrita1 wrote: > > I thought ...
6 years, 8 months ago (2014-04-21 19:06:20 UTC) #5
Hajime Morrita
On 2014/04/21 19:06:20, esprehn wrote: > On 2014/04/21 19:01:46, dglazkov wrote: > > On 2014/04/21 ...
6 years, 8 months ago (2014-04-21 19:24:58 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-21 19:25:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/245443002/1
6 years, 8 months ago (2014-04-21 19:25:14 UTC) #8
commit-bot: I haz the power
Change committed as 172063
6 years, 8 months ago (2014-04-21 19:33:53 UTC) #9
kenjibaheux
6 years, 8 months ago (2014-04-22 02:19:51 UTC) #10
Message was sent while issue was closed.
On 2014/04/21 19:33:53, I haz the power (commit-bot) wrote:
> Change committed as 172063

Thanks for tentatively enabling this feature in order to meet our TPM
guidelines.
Also, I just sent the intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Oo3I9jxMcvE

Powered by Google App Engine
This is Rietveld 408576698