Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2454413002: Break svg/parser/whitespace tests apart some more. (Closed)

Created:
4 years, 1 month ago by Stephen Chennney
Modified:
4 years, 1 month ago
Reviewers:
xidachen
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break svg/parser/whitespace tests apart some more. Some tests are still timing out on debug. Break them down some more in an attempt to get them passing. Next step will be to mark slow. TBR=xidachen@chromium.org BUG=630967 Committed: https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea Cr-Commit-Position: refs/heads/master@{#428419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14530 lines, -16423 lines) Patch
M third_party/WebKit/LayoutTests/svg/parser/resources/whitespace-helper.js View 3 chunks +40 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1.html View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1-expected.txt View 26 chunks +128 lines, -3328 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2.html View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2-expected.txt View 26 chunks +96 lines, -3296 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-invalid.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-invalid-expected.txt View 1 chunk +3203 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-integer-expected.txt View 1 chunk +4892 lines, -1310 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-expected.txt View 1 chunk +350 lines, -2534 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1.html View 2 chunks +2 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1-expected.txt View 1 chunk +1000 lines, -1000 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2.html View 2 chunks +2 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt View 1 chunk +1000 lines, -1000 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3.html View 2 chunks +2 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3-expected.txt View 1 chunk +1000 lines, -1000 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4.html View 2 chunks +2 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4-expected.txt View 1 chunk +1000 lines, -1000 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-number.html View 2 chunks +21 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-number-expected.txt View 52 chunks +1763 lines, -1763 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454413002/1
4 years, 1 month ago (2016-10-28 17:12:58 UTC) #2
xidachen
lgtm
4 years, 1 month ago (2016-10-28 17:16:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:57:38 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 18:07:40 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea
Cr-Commit-Position: refs/heads/master@{#428419}

Powered by Google App Engine
This is Rietveld 408576698