Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2454403002: Match more test targets for bash completion. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, enne (OOO), qyearsley
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Match more test targets for bash completion. I've realized that some test targets (e.g. interactive_ui_tests) are not found by tools/bash-completion script (because of indentation in BUILD.gn files that define these test targets). This CL fixes the script to also process those targets. BUG= Committed: https://crrev.com/990b7f8705ba497299fcf60193a9dc4e2316d7f8 Cr-Commit-Position: refs/heads/master@{#428459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/bash-completion View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Łukasz Anforowicz
dpranke@, could you please take a look? (just adding 2 characters (".*") to a regex ...
4 years, 1 month ago (2016-10-28 16:50:14 UTC) #2
Dirk Pranke
lgtm. +qyearsley, since you were looking at webkit-tools-completion.sh the other day, I think we can ...
4 years, 1 month ago (2016-10-28 19:02:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454403002/1
4 years, 1 month ago (2016-10-28 19:09:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 19:25:31 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:55:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/990b7f8705ba497299fcf60193a9dc4e2316d7f8
Cr-Commit-Position: refs/heads/master@{#428459}

Powered by Google App Engine
This is Rietveld 408576698