Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 24544004: Remove the chrome namespace around ChromeContent[Renderer]Client. (Closed)

Created:
7 years, 2 months ago by Wez
Modified:
7 years, 1 month ago
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, jam
Visibility:
Public.

Description

Remove the chrome namespace around ChromeContent[Renderer]Client. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233373

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Rebase & remove bits from wrong CL. #

Patch Set 5 : Fix CrOS build. #

Patch Set 6 : Fix ChromeContentClient for iOS #

Patch Set 7 : Rebase #

Patch Set 8 : Fix rebase. #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -79 lines) Patch
M chrome/app/chrome_main_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 4 6 chunks +6 lines, -10 lines 0 comments Download
M chrome/common/chrome_content_client_constants.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_content_client_ios.mm View 1 2 3 4 5 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_content_client_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 6 7 6 chunks +10 lines, -14 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.h View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 2 3 4 5 6 7 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Wez
Follow-up CL to remove chrome:: from ChromeContentClient.
7 years, 2 months ago (2013-09-25 17:19:16 UTC) #1
Wez
Ping. :)
7 years, 1 month ago (2013-11-03 04:15:50 UTC) #2
darin (slow to review)
LGTM except: https://codereview.chromium.org/24544004/diff/7001/chrome/browser/plugins/plugin_info_message_filter.cc File chrome/browser/plugins/plugin_info_message_filter.cc (right): https://codereview.chromium.org/24544004/diff/7001/chrome/browser/plugins/plugin_info_message_filter.cc#newcode53 chrome/browser/plugins/plugin_info_message_filter.cc:53: // Treat Remoting Viewer invocations by Chrome ...
7 years, 1 month ago (2013-11-03 07:56:53 UTC) #3
Wez
FYI https://codereview.chromium.org/24544004/diff/7001/chrome/browser/plugins/plugin_info_message_filter.cc File chrome/browser/plugins/plugin_info_message_filter.cc (right): https://codereview.chromium.org/24544004/diff/7001/chrome/browser/plugins/plugin_info_message_filter.cc#newcode53 chrome/browser/plugins/plugin_info_message_filter.cc:53: // Treat Remoting Viewer invocations by Chrome Remote ...
7 years, 1 month ago (2013-11-04 00:10:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/45001
7 years, 1 month ago (2013-11-04 00:10:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/165001
7 years, 1 month ago (2013-11-04 00:21:13 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-04 00:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/405001
7 years, 1 month ago (2013-11-04 01:44:11 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97047
7 years, 1 month ago (2013-11-04 04:18:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/405001
7 years, 1 month ago (2013-11-05 02:36:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/405001
7 years, 1 month ago (2013-11-05 02:59:00 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219388
7 years, 1 month ago (2013-11-05 07:04:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/405001
7 years, 1 month ago (2013-11-05 19:12:46 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/test/base/chrome_test_suite.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-05 19:13:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/685001
7 years, 1 month ago (2013-11-05 21:10:03 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 22:14:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/905001
7 years, 1 month ago (2013-11-06 01:48:13 UTC) #17
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-06 02:16:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/745002
7 years, 1 month ago (2013-11-06 02:18:17 UTC) #19
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-06 04:44:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/745002
7 years, 1 month ago (2013-11-06 05:35:30 UTC) #21
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220399
7 years, 1 month ago (2013-11-06 07:48:14 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/24544004/745002
7 years, 1 month ago (2013-11-06 18:31:17 UTC) #23
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 21:29:58 UTC) #24
Message was sent while issue was closed.
Change committed as 233373

Powered by Google App Engine
This is Rietveld 408576698