Issue 24544002: Macrofication of HInstruction constructors with context argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24544002: Macrofication of HInstruction constructors with context argument. (Closed)

Created:
7 years, 2 months ago by oliv

Modified:
7 years, 2 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Macrofication of HInstruction constructors with context argument. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16940

Patch Set 1 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -241 lines)			Patch
	M	src/hydrogen.cc	View		31 chunks	+39 lines, -76 lines	2 comments	Download
	M	src/hydrogen-instructions.h	View		33 chunks	+200 lines, -165 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

lgtm with nits https://codereview.chromium.org/24544002/diff/3004/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/24544002/diff/3004/src/hydrogen.cc#newcode3665 src/hydrogen.cc:3665: HStackCheck::cast(Add<HStackCheck>(HStackCheck::kBackwardsBranch)); nit: four indentation spaces https://codereview.chromium.org/24544002/diff/3004/src/hydrogen.cc#newcode3967 ...

7 years, 2 months ago (2013-09-25 11:44:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r16940.

Expand Messages | Collapse Messages