Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2454393003: Reland of Trigger Dangerous indicator for unsafe subresources (Closed)

Created:
4 years, 1 month ago by DaleCurtis
Modified:
4 years, 1 month ago
CC:
chromium-reviews, nasko+codewatch_chromium.org, grt+watch_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1 of https://codereview.chromium.org/2461093002/ ) Reason for revert: Broke build, https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/89477/steps/compile/logs/stdio Original issue's description: > Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4 id:60001 of https://codereview.chromium.org/2444383007/ ) > > Reason for revert: > Breaks MSan tests: > > First breaking build: > https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/2755 > > Original issue's description: > > Trigger Dangerous indicator for unsafe subresources > > > > Previously, the Dangerous indicator was not firing for subresources > > flagged by Safe Browsing as unsafe. This is because marking a > > subresource as unsafe was not triggering an omnibox update. We want to > > trigger an omnibox update whenever a URL is marked as > > whitelisted (either pending, meaning that an interstitial is showing, or > > whitelisted, meaning that an interstitial has been clicked through) in > > SafeBrowsingUIManager. > > > > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to > > DidChangeVisibleSecurityState() (since it's no longer just SSL > > information that can affect the omnibox security UI) and moves it to > > WebContents so that it can be called from SafeBrowsingUIManager. > > > > BUG=659713 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > > > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f > > Cr-Commit-Position: refs/heads/master@{#428223} > > TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=659713 > > Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b > Cr-Commit-Position: refs/heads/master@{#428520} TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org,tommycli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659713 Committed: https://crrev.com/6c58ed0944d915f84830ba571b9c85ecefab9913 Cr-Commit-Position: refs/heads/master@{#428534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -41 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager_unittest.cc View 3 chunks +112 lines, -0 lines 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
DaleCurtis
Created Reland of Trigger Dangerous indicator for unsafe subresources
4 years, 1 month ago (2016-10-28 23:01:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454393003/1
4 years, 1 month ago (2016-10-28 23:01:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 23:03:45 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 23:08:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c58ed0944d915f84830ba571b9c85ecefab9913
Cr-Commit-Position: refs/heads/master@{#428534}

Powered by Google App Engine
This is Rietveld 408576698