MacViews: Reveal scrollbars when resting on the trackpad.

ui/views/controls/scrollbar/cocoa_scroll_bar.mm

Index: ui/views/controls/scrollbar/cocoa_scroll_bar.mm
diff --git a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
index 3c6bb9b607f7881827abd4f587ee52ed03ff39c3..75377fbe7ec7b0d02b8e7ffaa39198bfcb320dde 100644
--- a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
+++ b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
@@ -168,6 +168,7 @@ CocoaScrollBar::CocoaScrollBar(bool horizontal)
           base::Bind(&CocoaScrollBar::HideScrollbar, base::Unretained(this)),
           false),
       thickness_animation_(this),
+      last_contents_scroll_offset_(0),
       is_expanded_(false),
       did_start_dragging_(false) {
   bridge_.reset([[ViewsScrollbarBridge alloc] initWithDelegate:this]);
@@ -322,10 +323,24 @@ void CocoaScrollBar::OnMouseExited(const ui::MouseEvent& event) {
 }
 
 //////////////////////////////////////////////////////////////////
-// CocoaScrollBar::BaseScrollBar:
+// CocoaScrollBar::ScrollBar:
+
+void CocoaScrollBar::Update(int viewport_size,
+                            int content_size,
+                            int contents_scroll_offset) {
+  // TODO(tapted): Pass in overscroll amounts from the Layer and "Squish" the
+  // scroller thumb accordingly.
+  BaseScrollBar::Update(viewport_size, content_size, contents_scroll_offset);
+
+  // Only reveal the scroller when |contents_scroll_offset| changes. Note this
+  // is different to GetPosition() which can change due to layout. A layout
+  // change can also change the offset; show the scroller in these cases. This
+  // is consistent with WebContents (Cocoa will also show a scroller with any
+  // mouse-initiated layout, but not programmatic size changes).
+  if (contents_scroll_offset == last_contents_scroll_offset_)
+    return;
 
-void CocoaScrollBar::ScrollToPosition(int position) {
-  BaseScrollBar::ScrollToPosition(position);
+  last_contents_scroll_offset_ = contents_scroll_offset;
 
   if (GetCocoaScrollBarThumb()->IsStatePressed())
     did_start_dragging_ = true;
@@ -336,6 +351,41 @@ void CocoaScrollBar::ScrollToPosition(int position) {
   }
 }
 
+void CocoaScrollBar::ObserveScrollEvent(const ui::ScrollEvent& event) {
+  // Do nothing if the delayed hide timer is running. This means there has been
+  // some recent scrolling in this direction already.
+  if (scroller_style_ != NSScrollerStyleOverlay ||
+      hide_scrollbar_timer_.IsRunning())

[spqchan, 2016/11/14 23:27:58]

multiline if statement needs curly brackets

[tapted, 2016/11/15 12:22:23]

Done. (I think technically the condition isn't a factor when prohibiting
braces-free - I've seen pkasting express a preference for this style [couldn't
find the link :/], but I've never settled on one or the other, unless a file has
a prevailing style already).

+    return;
+
+  // Otherwise, when starting the event stream, show an overlay scrollbar to
+  // indicate possible scroll directions, but do not start the hide timer.
+  if (event.momentum_phase() == ui::EventMomentumPhase::MAY_BEGIN) {
+    // Show only if the direction isn't yet known.
+    if (event.x_offset() == 0 && event.y_offset() == 0)
+      ShowScrollbar();
+    return;
+  }
+
+  // If the direction matches, do nothing. This is needed in addition to the
+  // hide timer check because Update() is called asynchronously, after event
+  // processing. So when |event| is the first event in a particular direction
+  // the hide timer will not have started.
+  if ((IsHorizontal() ? event.x_offset() : event.y_offset()) != 0)
+    return;
+
+  // Otherwise, scrolling has started, but not in this scroller direction. If
+  // already faded out, don't start another fade animation since that would
+  // immediately finish the first fade animation.
+  if (layer()->GetTargetOpacity() != 0) {
+    // If canceling rather than picking a direction, fade out after a delay.
+    if (event.momentum_phase() == ui::EventMomentumPhase::END)
+      hide_scrollbar_timer_.Reset();
+    else
+      HideScrollbar();  // Fade out immediately.
+  }
+}
+
 //////////////////////////////////////////////////////////////////
 // CocoaScrollBar::ViewsScrollbarBridge:
 
@@ -485,4 +535,9 @@ CocoaScrollBarThumb* CocoaScrollBar::GetCocoaScrollBarThumb() const {
   return static_cast<CocoaScrollBarThumb*>(GetThumb());
 }
 
+// static
+base::Timer* BaseScrollBar::GetHideTimerForTest(BaseScrollBar* scroll_bar) {
+  return &static_cast<CocoaScrollBar*>(scroll_bar)->hide_scrollbar_timer_;
+}
+
 }  // namespace views