MacViews: Reveal scrollbars when resting on the trackpad.

MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently they only appear once
scrolling has begun in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update the overlay scroll bars in an override of ScrollBar::Update(..)
rather than BaseScrollBar::ScrollToPosition(..). This is because changes
to scroll positions coming from a cc::InputHandler go through
ScrollView::OnLayerScrolled(), and not ScrollView::ScrollToOffset, so
they are not always seen by ScrollToPosition().

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894
Committed: https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721
Cr-Commit-Position: refs/heads/master@{#432417}

[tapted, 2016-11-11 04:20:47]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 04:20:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 04:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 04:37:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2016-11-14 03:23:35]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 03:23:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 05:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 05:29:45]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-11-14 06:12:26]

Description was changed from

==========
MacViews: Reveal scrollbars when resting on the trackpad

fixee


Revert "Split some stuff off"

This reverts commit 8a281a23be8637b7c0ac9ab78923b55266d82163.

BUG=
==========

to

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently the only appear when scrolling
starts in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

BUG=664894
==========

[tapted, 2016-11-14 06:12:27]

tapted@chromium.org changed reviewers:
+ spqchan@chromium.org

[tapted, 2016-11-14 06:14:19]

Description was changed from

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently the only appear when scrolling
starts in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

BUG=664894
==========

to

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently the only appear when scrolling
starts in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894
==========

[tapted, 2016-11-14 06:25:51]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 06:25:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-11-14 06:39:34]

Description was changed from

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently the only appear when scrolling
starts in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894
==========

to

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently they only appear once
scrolling has begun in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update the overlay scroll bars in an override of ScrollBar::Update(..)
rather than BaseScrollBar::ScrollToPosition(..). This is because changes
to scroll positions coming from a cc::InputHandler go through
ScrollView::OnLayerScrolled(), and not ScrollView::ScrollToOffset, so
they are not always seen by ScrollToPosition().

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894
==========

[tapted, 2016-11-14 06:40:57]

Hi Sarah, could please do the initial review. Thanks!

[commit-bot: I haz the power, 2016-11-14 06:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 06:41:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2016-11-14 11:06:40]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 11:06:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 12:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 12:08:22]

Dry run: This issue passed the CQ dry run.

[spqchan, 2016-11-14 23:27:58]

LGTM with some nits

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scroll_view_unittest.cc (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scroll_view_unittest.cc:184: // Call this before adding the
ScrollView to test with overlay scroll bars.
"scroll bars" -> "scrollbars"

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/cocoa_scroll_bar.h (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scrollbar/cocoa_scroll_bar.h:108: // The scroll offset from
the last adjustment to the scroll bar.
"scroll bar" -> "scrollbar

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/cocoa_scroll_bar.mm (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scrollbar/cocoa_scroll_bar.mm:358:
hide_scrollbar_timer_.IsRunning())
multiline if statement needs curly brackets

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/scroll_bar.h (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scrollbar/scroll_bar.h:97: // ScrollView. E.g., this may
reveal an overlay scroll bar to indicate
"scroll bar" -> "scrollbar"

[tapted, 2016-11-15 07:26:10]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 07:26:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 08:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 08:22:20]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-11-15 12:22:22]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-11-15 12:22:23]

+sky - please take a look (OWNERS for all files except
event_generator_delegate_mac.mm [but of course you can look there too :) ]).
Thanks!

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scroll_view_unittest.cc (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scroll_view_unittest.cc:184: // Call this before adding the
ScrollView to test with overlay scroll bars.
On 2016/11/14 23:27:58, spqchan wrote:
> "scroll bars" -> "scrollbars"

Done.

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/cocoa_scroll_bar.h (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scrollbar/cocoa_scroll_bar.h:108: // The scroll offset from
the last adjustment to the scroll bar.
On 2016/11/14 23:27:58, spqchan wrote:
> "scroll bar" -> "scrollbar

Done.

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/cocoa_scroll_bar.mm (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scrollbar/cocoa_scroll_bar.mm:358:
hide_scrollbar_timer_.IsRunning())
On 2016/11/14 23:27:58, spqchan wrote:
> multiline if statement needs curly brackets

Done. (I think technically the condition isn't a factor when prohibiting
braces-free - I've seen pkasting express a preference for this style [couldn't
find the link :/], but I've never settled on one or the other, unless a file has
a prevailing style already).

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scrollbar/scroll_bar.h (right):

https://codereview.chromium.org/2454323002/diff/80001/ui/views/controls/scrol...
ui/views/controls/scrollbar/scroll_bar.h:97: // ScrollView. E.g., this may
reveal an overlay scroll bar to indicate
On 2016/11/14 23:27:58, spqchan wrote:
> "scroll bar" -> "scrollbar"

Done.

https://codereview.chromium.org/2454323002/diff/100001/ui/views/controls/scro...
File ui/views/controls/scrollbar/base_scroll_bar.h (right):

https://codereview.chromium.org/2454323002/diff/100001/ui/views/controls/scro...
ui/views/controls/scrollbar/base_scroll_bar.h:119: static base::Timer*
GetHideTimerForTest(BaseScrollBar* scroll_bar);
(note: This is a bit of a trade-off. I didn't give cocoa_scroll_bar.h its own
test API since scroll_view_unittest.cc wouldn't be able to #include
cocoa_scroll_bar.h [because it's objective-C]. But if you don't like this I can
explore some options. E.g. I can move the #ifdef (MAC) unittests out to their
own, .mm. file [and make separate .h .cc for the current test api so both
_unittest.xx files can use it] - I think that will work.

There might also be a way to make cocoa_scroll_bar.h #includable in .cc files
with a bit of indirection.)

[sky, 2016-11-15 14:19:51]

LGTM

https://codereview.chromium.org/2454323002/diff/100001/ui/events/test/event_g...
File ui/events/test/event_generator.h (right):

https://codereview.chromium.org/2454323002/diff/100001/ui/events/test/event_g...
ui/events/test/event_generator.h:356: void TrackpadRest();
optional: for clarity name this GenerateTrackpadReset.

[tapted, 2016-11-15 23:46:05]

Patchset #7 (id:120001) has been deleted

[tapted, 2016-11-16 00:40:07]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:51:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tapted, 2016-11-16 01:41:13]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 01:41:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-11-16 01:49:35]

Patchset #7 (id:140001) has been deleted

[tapted, 2016-11-16 02:54:46]

Thanks all!

https://codereview.chromium.org/2454323002/diff/100001/ui/events/test/event_g...
File ui/events/test/event_generator.h (right):

https://codereview.chromium.org/2454323002/diff/100001/ui/events/test/event_g...
ui/events/test/event_generator.h:356: void TrackpadRest();
On 2016/11/15 14:19:51, sky wrote:
> optional: for clarity name this GenerateTrackpadReset.

Done.

[tapted, 2016-11-16 02:54:52]

The CQ bit was unchecked by tapted@chromium.org

[tapted, 2016-11-16 02:54:58]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-11-16 02:54:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
spqchan@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2454323002/#ps160001
(title: "GenerateTrackpadRest")

[commit-bot: I haz the power, 2016-11-16 02:55:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 03:02:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 03:02:50]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tapted, 2016-11-16 06:29:32]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-11-16 06:29:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
spqchan@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2454323002/#ps180001
(title: "rebase for r432358")

[commit-bot: I haz the power, 2016-11-16 06:30:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 08:04:34]

Description was changed from

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently they only appear once
scrolling has begun in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update the overlay scroll bars in an override of ScrollBar::Update(..)
rather than BaseScrollBar::ScrollToPosition(..). This is because changes
to scroll positions coming from a cc::InputHandler go through
ScrollView::OnLayerScrolled(), and not ScrollView::ScrollToOffset, so
they are not always seen by ScrollToPosition().

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894
==========

to

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently they only appear once
scrolling has begun in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update the overlay scroll bars in an override of ScrollBar::Update(..)
rather than BaseScrollBar::ScrollToPosition(..). This is because changes
to scroll positions coming from a cc::InputHandler go through
ScrollView::OnLayerScrolled(), and not ScrollView::ScrollToOffset, so
they are not always seen by ScrollToPosition().

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894
==========

[commit-bot: I haz the power, 2016-11-16 08:04:35]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-11-16 08:06:20]

Description was changed from

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently they only appear once
scrolling has begun in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update the overlay scroll bars in an override of ScrollBar::Update(..)
rather than BaseScrollBar::ScrollToPosition(..). This is because changes
to scroll positions coming from a cc::InputHandler go through
ScrollView::OnLayerScrolled(), and not ScrollView::ScrollToOffset, so
they are not always seen by ScrollToPosition().

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894
==========

to

==========
MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently they only appear once
scrolling has begun in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update the overlay scroll bars in an override of ScrollBar::Update(..)
rather than BaseScrollBar::ScrollToPosition(..). This is because changes
to scroll positions coming from a cc::InputHandler go through
ScrollView::OnLayerScrolled(), and not ScrollView::ScrollToOffset, so
they are not always seen by ScrollToPosition().

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG=664894

Committed: https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721
Cr-Commit-Position: refs/heads/master@{#432417}
==========

[commit-bot: I haz the power, 2016-11-16 08:06:21]

Patchset 8 (id:??) landed as
https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721
Cr-Commit-Position: refs/heads/master@{#432417}