Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 24543002: Rename "OptimizingCompiler" to the more suitable "RecompileJob". (Closed)

Created:
7 years, 2 months ago by Yang
Modified:
7 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Rename "OptimizingCompiler" to the more suitable "RecompileJob". R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16939

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -92 lines) Patch
M src/compiler.h View 4 chunks +6 lines, -7 lines 0 comments Download
M src/compiler.cc View 8 chunks +32 lines, -34 lines 0 comments Download
M src/optimizing-compiler-thread.h View 5 chunks +9 lines, -9 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 1 8 chunks +34 lines, -38 lines 0 comments Download
M src/runtime.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 2 months ago (2013-09-25 09:14:24 UTC) #1
mvstanton
LGTM with one comment nit. You could rename the optimizing compiler thread to RecompilationThread for ...
7 years, 2 months ago (2013-09-25 09:22:25 UTC) #2
Yang
On 2013/09/25 09:22:25, mvstanton wrote: > LGTM with one comment nit. You could rename the ...
7 years, 2 months ago (2013-09-25 09:58:43 UTC) #3
Yang
7 years, 2 months ago (2013-09-25 10:01:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698