Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: components/printing/renderer/print_web_view_helper_mac.mm

Issue 2454293004: Printing: Fix undefined behavior for near 0 scaling (Closed)
Patch Set: Fix declaration Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/printing/renderer/print_web_view_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/printing/renderer/print_web_view_helper_mac.mm
diff --git a/components/printing/renderer/print_web_view_helper_mac.mm b/components/printing/renderer/print_web_view_helper_mac.mm
index 2e08eb53e35304bc65647e8b2830c6d460a3d05f..daf2a9845c52a68efcce163be39955f3836e6eab 100644
--- a/components/printing/renderer/print_web_view_helper_mac.mm
+++ b/components/printing/renderer/print_web_view_helper_mac.mm
@@ -114,7 +114,8 @@ void PrintWebViewHelper::RenderPage(const PrintMsg_Print_Params& params,
PdfMetafileSkia* metafile,
gfx::Size* page_size,
gfx::Rect* content_rect) {
- double scale_factor = params.scale_factor > 0 ? params.scale_factor : 1.0f;
+ double scale_factor =
+ params.scale_factor >= kEpsilon ? params.scale_factor : 1.0f;
double webkit_shrink_factor = frame->getPrintPageShrink(page_number);
PageSizeMargins page_layout_in_points;
gfx::Rect content_area;
« no previous file with comments | « components/printing/renderer/print_web_view_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698