Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: components/printing/renderer/print_web_view_helper.h

Issue 2454293004: Printing: Fix undefined behavior for near 0 scaling (Closed)
Patch Set: Add constant Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PRINTING_RENDERER_PRINT_WEB_VIEW_HELPER_H_ 5 #ifndef COMPONENTS_PRINTING_RENDERER_PRINT_WEB_VIEW_HELPER_H_
6 #define COMPONENTS_PRINTING_RENDERER_PRINT_WEB_VIEW_HELPER_H_ 6 #define COMPONENTS_PRINTING_RENDERER_PRINT_WEB_VIEW_HELPER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 } 44 }
45 45
46 namespace blink { 46 namespace blink {
47 class WebFrame; 47 class WebFrame;
48 class WebLocalFrame; 48 class WebLocalFrame;
49 class WebView; 49 class WebView;
50 } 50 }
51 51
52 namespace printing { 52 namespace printing {
53 53
54 constexpr double kEpsilon = .01f;
Lei Zhang 2016/10/29 00:59:27 Mmm, this adds printing::kEpsilon. Can we declare
rbpotter 2016/10/29 01:09:38 Done.
54 struct PageSizeMargins; 55 struct PageSizeMargins;
55 class PrepareFrameAndViewForPrint; 56 class PrepareFrameAndViewForPrint;
56 57
57 // Stores reference to frame using WebVew and unique name. 58 // Stores reference to frame using WebVew and unique name.
58 // Workaround to modal dialog issue on Linux. crbug.com/236147. 59 // Workaround to modal dialog issue on Linux. crbug.com/236147.
59 // If WebFrame someday supports WeakPtr, we should use it here. 60 // If WebFrame someday supports WeakPtr, we should use it here.
60 class FrameReference { 61 class FrameReference {
61 public: 62 public:
62 explicit FrameReference(blink::WebLocalFrame* frame); 63 explicit FrameReference(blink::WebLocalFrame* frame);
63 FrameReference(); 64 FrameReference();
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 base::Closure on_stop_loading_closure_; 527 base::Closure on_stop_loading_closure_;
527 528
528 base::WeakPtrFactory<PrintWebViewHelper> weak_ptr_factory_; 529 base::WeakPtrFactory<PrintWebViewHelper> weak_ptr_factory_;
529 530
530 DISALLOW_COPY_AND_ASSIGN(PrintWebViewHelper); 531 DISALLOW_COPY_AND_ASSIGN(PrintWebViewHelper);
531 }; 532 };
532 533
533 } // namespace printing 534 } // namespace printing
534 535
535 #endif // COMPONENTS_PRINTING_RENDERER_PRINT_WEB_VIEW_HELPER_H_ 536 #endif // COMPONENTS_PRINTING_RENDERER_PRINT_WEB_VIEW_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698