Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2454293002:
Roll isolate binaries generated at infra@6f1765e (Closed)
|
Created:
4 years, 1 month ago by djd-OOO-Apr2017 Modified:
4 years, 1 month ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll isolate binaries generated at infra@6f1765e
This includes the recent roll of luci-go (infra@082dcd6) and the upgrade
to Go 1.7.3 (infra@d111717).
https://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise-64/builds/4396
https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.10-64/builds/3478
https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/builds/4292
BUG=653723
Committed: https://crrev.com/5abcfa0d769ca821f045bb6550c543ee004b8c39
Cr-Commit-Position: refs/heads/master@{#428830}
Patch Set 1 #
Messages
Total messages: 26 (12 generated)
The CQ bit was checked by djd@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
djd@chromium.org changed reviewers: + tansell@chromium.org
Tim, can you give this an initial sanity check? I've kicked off a CQ dry run.
On 2016/10/28 02:10:37, djd wrote: > Tim, can you give this an initial sanity check? I've kicked off a CQ dry run. LGTM but I don't think we should do a roll on Friday.
On 2016/10/28 02:32:06, mithro wrote: > On 2016/10/28 02:10:37, djd wrote: > > Tim, can you give this an initial sanity check? I've kicked off a CQ dry run. > > LGTM but I don't think we should do a roll on Friday. Yup, no rush – I can submit MTV Monday.
Description was changed from ========== Roll isolate binaries generated at infra@6f1765e This includes the recent roll of luci-go (infra@082dcd6) and the upgrade to Go 1.7.3 (infra@d111717). https://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/... BUG=653723 ========== to ========== Roll isolate binaries generated at infra@6f1765e This includes the recent roll of luci-go (infra@082dcd6) and the upgrade to Go 1.7.3 (infra@d111717). https://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/... BUG=653723 ==========
On 2016/10/28 02:36:40, djd wrote: > On 2016/10/28 02:32:06, mithro wrote: > > On 2016/10/28 02:10:37, djd wrote: > > > Tim, can you give this an initial sanity check? I've kicked off a CQ dry > run. > > > > LGTM but I don't think we should do a roll on Friday. > > Yup, no rush – I can submit MTV Monday. Results so far are positive: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... 326479 5 mins, 3 secs 326480 4 mins, 28 secs 326481 4 mins, 41 secs 326482 5 mins, 14 secs 326483 2 mins, 32 secs <-- this CL https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng 324278 1 mins, 52 secs 324279 1 mins, 37 secs 324280 1 mins, 41 secs 324282 1 mins, 38 secs <-- this CL https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng 320971 1 mins, 56 secs 320972 2 mins, 7 secs 320973 2 mins, 7 secs 320974 2 mins, 16 secs 320975 2 mins, 15 secs <-- this CL As we've seen, the timings from these try servers are not very reliable – but at least it indicates that there's not a major regression.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/28 02:32:06, mithro wrote: > On 2016/10/28 02:10:37, djd wrote: > > Tim, can you give this an initial sanity check? I've kicked off a CQ dry run. > > LGTM but I don't think we should do a roll on Friday. FTR, I don't mind you guys doing rolls on Friday since it's still a complete work day in MTV to do a revert. I'm not going to do it because I happen today I'm mostly OOO but otherwise I'd have CQ'ed it in but if someone else can keep an eye, please CQ it. Thanks
On 2016/10/28 12:51:55, M-A Ruel wrote: > On 2016/10/28 02:32:06, mithro wrote: > > On 2016/10/28 02:10:37, djd wrote: > > > Tim, can you give this an initial sanity check? I've kicked off a CQ dry > run. > > > > LGTM but I don't think we should do a roll on Friday. > > FTR, I don't mind you guys doing rolls on Friday since it's still a complete > work day in MTV to do a revert. I'm not going to do it because I happen today > I'm mostly OOO but otherwise I'd have CQ'ed it in but if someone else can keep > an eye, please CQ it. > > Thanks My perf builder is super noisy on such small numbers after I brought faster compression lib. Still, since 1.7 was rolled, it does show somewhat lower numbers: https://chromeperf.appspot.com/report?sid=1d71802b62b3df6b51bd51a969ff5a3554c... (you must login to see it)
On 2016/10/28 13:11:25, tandrii(chromium) wrote: > On 2016/10/28 12:51:55, M-A Ruel wrote: > > On 2016/10/28 02:32:06, mithro wrote: > > > On 2016/10/28 02:10:37, djd wrote: > > > > Tim, can you give this an initial sanity check? I've kicked off a CQ dry > > run. > > > > > > LGTM but I don't think we should do a roll on Friday. > > > > FTR, I don't mind you guys doing rolls on Friday since it's still a complete > > work day in MTV to do a revert. I'm not going to do it because I happen today > > I'm mostly OOO but otherwise I'd have CQ'ed it in but if someone else can keep > > an eye, please CQ it. > > > > Thanks > > My perf builder is super noisy on such small numbers after I brought faster > compression lib. Still, since 1.7 was rolled, it does show somewhat lower > numbers: > > https://chromeperf.appspot.com/report?sid=1d71802b62b3df6b51bd51a969ff5a3554c... > (you must login to see it) I'm planning to submit today – let me know if anyone has concerns. After it's been out for a couple of days, I'll repeat my logs analysis (see attached issue) to see what effect it's had. Let me know if there are particular builders you want me to include in that.
The CQ bit was checked by djd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/10/31 at 18:20:27, commit-bot wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Actually, looks like a need an LGTM from one of ye OWNERS (it's my first day – still trying to get my head around this). maurel or tandrii, would you mind taking a look?
djd@chromium.org changed reviewers: + maruel@chromium.org, tandrii@chromium.org
lgtm
The CQ bit was checked by djd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll isolate binaries generated at infra@6f1765e This includes the recent roll of luci-go (infra@082dcd6) and the upgrade to Go 1.7.3 (infra@d111717). https://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/... BUG=653723 ========== to ========== Roll isolate binaries generated at infra@6f1765e This includes the recent roll of luci-go (infra@082dcd6) and the upgrade to Go 1.7.3 (infra@d111717). https://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/... BUG=653723 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll isolate binaries generated at infra@6f1765e This includes the recent roll of luci-go (infra@082dcd6) and the upgrade to Go 1.7.3 (infra@d111717). https://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/... BUG=653723 ========== to ========== Roll isolate binaries generated at infra@6f1765e This includes the recent roll of luci-go (infra@082dcd6) and the upgrade to Go 1.7.3 (infra@d111717). https://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.... https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/... BUG=653723 Committed: https://crrev.com/5abcfa0d769ca821f045bb6550c543ee004b8c39 Cr-Commit-Position: refs/heads/master@{#428830} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5abcfa0d769ca821f045bb6550c543ee004b8c39 Cr-Commit-Position: refs/heads/master@{#428830} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
