Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/javascript/Document.cpp

Issue 2454263002: Fix more FX_BOOL / int noise in core/fpdfsdk (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fxcodec/codec/fx_codec_jpeg.cpp ('K') | « core/fxge/win32/fx_win32_gdipext.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/Document.cpp
diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp
index 0c2e3f7399add2166c5151fc876ce1a69c9f2484..ea489c993bd1e80bd856f96ec63bf232631352d5 100644
--- a/fpdfsdk/javascript/Document.cpp
+++ b/fpdfsdk/javascript/Document.cpp
@@ -733,7 +733,7 @@ FX_BOOL Document::mailDoc(IJS_Context* cc,
v8::Local<v8::Object> pObj = params[0].ToV8Object(pRuntime);
v8::Local<v8::Value> pValue = pRuntime->GetObjectProperty(pObj, L"bUI");
- bUI = CJS_Value(pRuntime, pValue).ToInt(pRuntime);
+ bUI = CJS_Value(pRuntime, pValue).ToBool(pRuntime);
Tom Sepez 2016/10/27 23:40:46 consistency with line 720.
pValue = pRuntime->GetObjectProperty(pObj, L"cTo");
cTo = CJS_Value(pRuntime, pValue).ToCFXWideString(pRuntime);
« core/fxcodec/codec/fx_codec_jpeg.cpp ('K') | « core/fxge/win32/fx_win32_gdipext.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698