Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2454263002: Fix more FX_BOOL / int noise in core/fpdfsdk (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix more FX_BOOL / int noise in core/fpdfsdk Committed: https://pdfium.googlesource.com/pdfium/+/71ba5883dd00145b2256935635492cbcc8d94bac

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M core/fxcodec/codec/ccodec_jpegmodule.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpeg.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/2454263002/diff/1/fpdfsdk/javascript/Document.cpp File fpdfsdk/javascript/Document.cpp (right): https://codereview.chromium.org/2454263002/diff/1/fpdfsdk/javascript/Document.cpp#newcode736 fpdfsdk/javascript/Document.cpp:736: bUI = CJS_Value(pRuntime, pValue).ToBool(pRuntime); consistency with ...
4 years, 1 month ago (2016-10-27 23:40:46 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/2454263002/diff/1/core/fxcodec/codec/fx_codec_jpeg.cpp File core/fxcodec/codec/fx_codec_jpeg.cpp (right): https://codereview.chromium.org/2454263002/diff/1/core/fxcodec/codec/fx_codec_jpeg.cpp#newcode454 core/fxcodec/codec/fx_codec_jpeg.cpp:454: return 0; return false?
4 years, 1 month ago (2016-10-28 00:50:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454263002/20001
4 years, 1 month ago (2016-10-28 16:21:54 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 16:35:54 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/71ba5883dd00145b2256935635492cbcc8d9...

Powered by Google App Engine
This is Rietveld 408576698