Ensure HtmlWorkManager is subscribed to the right stream for invalidations in the presence of Sourc…

Ensure HtmlWorkManager is subscribed to the right stream for invalidations in the presence of SourceFactory changes

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/cc12877f560061e1a06ac904e78bf457feaabe7d

[mfairhurst, 2016-10-28 18:47:40]

Description was changed from

==========
Ensure HtmlWorkManager is subscribed to the right stream for invalidations in
the presence of SourceFactory changes

BUG=
==========

to

==========
Ensure HtmlWorkManager is subscribed to the right stream for invalidations in
the presence of SourceFactory changes

BUG=
==========

[mfairhurst, 2016-10-28 18:47:40]

mfairhurst@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-10-28 19:04:45]

lgtm

https://codereview.chromium.org/2454233003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/html_work_manager_integration_test.dart (right):

https://codereview.chromium.org/2454233003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/html_work_manager_integration_test.dart:24:
defineReflectiveTests(HtmlWorkManagerIntegrationTest);
I would just add it to html_work_manager_test.dart

https://codereview.chromium.org/2454233003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/html_work_manager_test.dart (right):

https://codereview.chromium.org/2454233003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/html_work_manager_test.dart:314: // the production
version is a stream that carries messages from the cache
Write full sentences please :-)
Start with a capital letter and end with a dot.

[mfairhurst, 2016-10-28 19:22:33]

Updated according to feedback from Konstantin

[scheglov, 2016-10-28 19:28:45]

Still LGTM.

[Brian Wilkerson, 2016-10-31 14:03:37]

lgtm

[mfairhurst, 2016-10-31 19:57:28]

Description was changed from

==========
Ensure HtmlWorkManager is subscribed to the right stream for invalidations in
the presence of SourceFactory changes

BUG=
==========

to

==========
Ensure HtmlWorkManager is subscribed to the right stream for invalidations in
the presence of SourceFactory changes

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cc12877f560061e1a06ac904e78bf457feaabe7d
==========

[mfairhurst, 2016-10-31 19:57:30]

Committed patchset #2 (id:20001) manually as
cc12877f560061e1a06ac904e78bf457feaabe7d (presubmit successful).