Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2454203002: Revert of cc : Move screen space scale factor to root transform node (Closed)

Created:
4 years, 1 month ago by jaydasika
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of cc : Move screen space scale factor to root transform node (patchset #1 id:1 of https://codereview.chromium.org/2452023003/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=660047 Original issue's description: > cc : Move screen space scale factor to root transform node > > This CL computes the screen space scale factor which is > combined form scale factors of device transform, device > scale factor and page scale factor(if required), and stores > it on the root transform node as its surface contents scale. > This also implicitly fixes a clipping bug. > TransformTree::ComputeTransforms(a, b) should return the > transform between a and b without the surface contents > scale. But, since screen space scale was baked into the > local transform of the contents root node (before this CL), > ComputeTransform(a, root) was having the scale baked in. > (and this caused the bug) > > BUG=651584 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Review-Url: https://codereview.chromium.org/2408243002 > Cr-Commit-Position: refs/heads/master@{#427366} > (cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6) > > Committed: https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b25318d43700fc TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -204 lines) Patch
M cc/trees/draw_property_utils.cc View 10 chunks +82 lines, -54 lines 0 comments Download
M cc/trees/effect_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 3 chunks +2 lines, -37 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M cc/trees/property_tree.h View 2 chunks +3 lines, -9 lines 0 comments Download
M cc/trees/property_tree.cc View 4 chunks +25 lines, -56 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jaydasika
Created Revert of cc : Move screen space scale factor to root transform node
4 years, 1 month ago (2016-10-27 21:02:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454203002/1
4 years, 1 month ago (2016-10-27 21:03:45 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 21:09:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698