Chromium Code Reviews
DescriptionRevert of cc : Move screen space scale factor to root transform node (patchset #1 id:1 of https://codereview.chromium.org/2452023003/ )
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=660047
Original issue's description:
> cc : Move screen space scale factor to root transform node
>
> This CL computes the screen space scale factor which is
> combined form scale factors of device transform, device
> scale factor and page scale factor(if required), and stores
> it on the root transform node as its surface contents scale.
> This also implicitly fixes a clipping bug.
> TransformTree::ComputeTransforms(a, b) should return the
> transform between a and b without the surface contents
> scale. But, since screen space scale was baked into the
> local transform of the contents root node (before this CL),
> ComputeTransform(a, root) was having the scale baked in.
> (and this caused the bug)
>
> BUG=651584
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Review-Url: https://codereview.chromium.org/2408243002
> Cr-Commit-Position: refs/heads/master@{#427366}
> (cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b25318d43700fc
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651584
Patch Set 1 #
Messages
Total messages: 4 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||