Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2454183002: Revert of Moving gRPC support interfaces out of cronet and into a new component. (Closed)

Created:
4 years, 1 month ago by mohsen
Modified:
4 years, 1 month ago
Reviewers:
mef, Garrett Casto, blundell
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, sdefresne
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset #67 id:1300001 of https://codereview.chromium.org/2273403003/ ) Reason for revert: Causes failures on "Mac10.9 Tests" builder: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/30817 An example failure: [ RUN ] BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StartExampleBidiStream/1 [12832:13571:1027/123821:4064068458447:ERROR:quic_simple_server.cc(97)] Listen() failed: net::ERR_ADDRESS_IN_USE [12832:13571:1027/123821:4064068534048:FATAL:quic_test_server.cc(87)] Check failed: rv >= 0 (-147 vs. 0)Quic server fails to start 0 components_unittests 0x00000001095d79c3 _ZN4base5debug10StackTraceC1Ev + 19 1 components_unittests 0x00000001095ee9d7 _ZN7logging10LogMessageD2Ev + 71 2 components_unittests 0x0000000109461920 _ZN12grpc_support29StartQuicServerOnServerThreadERKN4base8FilePathEPNS0_13WaitableEventE + 608 3 components_unittests 0x00000001095d7f49 _ZN4base5debug13TaskAnnotator7RunTaskEPKcPNS_11PendingTaskE + 217 4 components_unittests 0x00000001095f8236 _ZN4base11MessageLoop7RunTaskEPNS_11PendingTaskE + 390 5 components_unittests 0x00000001095f850c _ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE + 44 6 components_unittests 0x00000001095f8853 _ZN4base11MessageLoop6DoWorkEv + 371 7 components_unittests 0x00000001095fa223 _ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE + 83 8 components_unittests 0x00000001095f7f9e _ZN4base11MessageLoop10RunHandlerEv + 94 9 components_unittests 0x00000001096103f3 _ZN4base7RunLoop3RunEv + 115 10 components_unittests 0x0000000109630f92 _ZN4base6Thread10ThreadMainEv + 386 11 components_unittests 0x000000010962c6d7 _ZN4base12_GLOBAL__N_110ThreadFuncEPv + 87 12 libsystem_pthread.dylib 0x00007fff8e718899 _pthread_body + 138 13 libsystem_pthread.dylib 0x00007fff8e71872a _pthread_struct_init + 0 14 libsystem_pthread.dylib 0x00007fff8e71cfc9 thread_start + 13 Original issue's description: > Moving gRPC support interfaces out of cronet and into a new component. > > BUG=650462 > > Committed: https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31 > Cr-Commit-Position: refs/heads/master@{#428099} TBR=mef@chromium.org,blundell@chromium.org,gcasto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650462 Committed: https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1 Cr-Commit-Position: refs/heads/master@{#428122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2082 lines, -2339 lines) Patch
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/ios/BUILD.gn View 4 chunks +11 lines, -14 lines 0 comments Download
M components/cronet/ios/Cronet.h View 2 chunks +3 lines, -5 lines 0 comments Download
M components/cronet/ios/Cronet.mm View 2 chunks +5 lines, -5 lines 0 comments Download
A components/cronet/ios/cronet_bidirectional_stream.h View 1 chunk +232 lines, -0 lines 0 comments Download
A components/cronet/ios/cronet_bidirectional_stream.cc View 1 chunk +390 lines, -0 lines 0 comments Download
A components/cronet/ios/cronet_c_for_grpc.h View 1 chunk +243 lines, -0 lines 0 comments Download
A components/cronet/ios/cronet_c_for_grpc.cc View 1 chunk +290 lines, -0 lines 0 comments Download
M components/cronet/ios/cronet_environment.h View 2 chunks +8 lines, -8 lines 0 comments Download
M components/cronet/ios/cronet_environment.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/cronet/ios/test/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download
A components/cronet/ios/test/cronet_bidirectional_stream_test.mm View 1 chunk +709 lines, -0 lines 0 comments Download
M components/cronet/ios/test/cronet_http_test.mm View 4 chunks +16 lines, -16 lines 0 comments Download
D components/cronet/ios/test/get_stream_engine.mm View 1 chunk +0 lines, -18 lines 0 comments Download
A components/cronet/ios/test/quic_test_server.h View 1 chunk +32 lines, -0 lines 0 comments Download
A components/cronet/ios/test/quic_test_server.cc View 1 chunk +136 lines, -0 lines 0 comments Download
D components/cronet/ios/test/start_cronet.h View 1 chunk +0 lines, -10 lines 0 comments Download
D components/cronet/ios/test/start_cronet.mm View 1 chunk +0 lines, -40 lines 0 comments Download
D components/grpc_support/BUILD.gn View 1 chunk +0 lines, -33 lines 0 comments Download
D components/grpc_support/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/grpc_support/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/grpc_support/README.md View 1 chunk +0 lines, -14 lines 0 comments Download
D components/grpc_support/bidirectional_stream.h View 1 chunk +0 lines, -236 lines 0 comments Download
D components/grpc_support/bidirectional_stream.cc View 1 chunk +0 lines, -401 lines 0 comments Download
D components/grpc_support/bidirectional_stream_c.cc View 1 chunk +0 lines, -285 lines 0 comments Download
D components/grpc_support/bidirectional_stream_unittest.cc View 1 chunk +0 lines, -655 lines 0 comments Download
D components/grpc_support/include/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/grpc_support/include/bidirectional_stream_c.h View 1 chunk +0 lines, -246 lines 0 comments Download
D components/grpc_support/include/headers.gni View 1 chunk +0 lines, -2 lines 0 comments Download
D components/grpc_support/test/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D components/grpc_support/test/get_stream_engine.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/grpc_support/test/get_stream_engine.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D components/grpc_support/test/quic_test_server.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/grpc_support/test/quic_test_server.cc View 1 chunk +0 lines, -134 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mohsen
Created Revert of Moving gRPC support interfaces out of cronet and into a new component.
4 years, 1 month ago (2016-10-27 20:10:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454183002/1
4 years, 1 month ago (2016-10-27 20:10:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 20:12:06 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1 Cr-Commit-Position: refs/heads/master@{#428122}
4 years, 1 month ago (2016-10-27 20:14:48 UTC) #6
Jackie Quinn
4 years, 1 month ago (2016-10-28 01:37:59 UTC) #7
Message was sent while issue was closed.
On 2016/10/27 20:14:48, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1
> Cr-Commit-Position: refs/heads/master@{#428122}

The reverted CL was also failing
BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest on all
iOS device bots.

Powered by Google App Engine
This is Rietveld 408576698