Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2454173003: fix #27429, html wrapper methods pass incorrect number of arguments (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27429, html wrapper methods pass incorrect number of arguments R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/644c1dca75346c1308f396f572541cac4d0f95e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10074 lines, -10076 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 326 chunks +2516 lines, -2516 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 326 chunks +2516 lines, -2516 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 326 chunks +2516 lines, -2516 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 326 chunks +2516 lines, -2516 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +9 lines, -11 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Here's a straightforward fix. I think there are other approaches -- even with understanding renames ...
4 years, 1 month ago (2016-10-27 19:31:46 UTC) #2
vsm
lgtm!
4 years, 1 month ago (2016-10-27 20:15:06 UTC) #3
Jennifer Messerly
4 years, 1 month ago (2016-10-27 20:16:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
644c1dca75346c1308f396f572541cac4d0f95e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698