Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2454133002: [Bindings] Reformat template files for Interface (1/4) (Closed)

Created:
4 years, 1 month ago by peria
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat template files for Interface I'm planning to change the format of templates as follows: - Interfaces (this CL) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (https://codereview.chromium.org/2449043007/) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 Committed: https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779 Cr-Commit-Position: refs/heads/master@{#428323}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4486 lines, -5007 lines) Patch
M third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl View 1 chunk +38 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl View 1 chunk +13 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl View 1 29 chunks +486 lines, -519 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.h.tmpl View 1 2 chunks +152 lines, -157 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl View 5 chunks +155 lines, -166 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl View 2 chunks +17 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl View 1 chunk +32 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h View 1 chunk +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp View 1 chunk +20 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h View 1 chunk +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp View 1 chunk +30 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h View 1 chunk +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp View 1 chunk +21 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 chunk +20 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp View 1 chunk +21 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h View 1 chunk +25 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 1 chunk +82 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h View 1 chunk +29 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp View 1 chunk +106 lines, -117 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +39 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.h View 1 chunk +29 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 2 chunks +61 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.h View 1 chunk +30 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 2 chunks +69 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.h View 1 chunk +30 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 2 chunks +69 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +42 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 3 chunks +445 lines, -486 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.h View 1 chunk +28 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 2 chunks +169 lines, -193 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +31 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 2 chunks +81 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 3 chunks +53 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.h View 1 chunk +26 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 2 chunks +90 lines, -98 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 chunk +76 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 chunk +33 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +47 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h View 1 chunk +23 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp View 1 chunk +33 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 1 chunk +20 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp View 1 chunk +19 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 chunk +34 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h View 1 chunk +26 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 chunk +32 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h View 1 chunk +23 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 chunk +39 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h View 1 chunk +25 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +33 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h View 1 chunk +25 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +32 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +21 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp View 1 chunk +37 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp View 1 chunk +114 lines, -120 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +34 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h View 1 chunk +59 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 3 chunks +212 lines, -241 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 2 chunks +86 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +21 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 1 chunk +49 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.h View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +36 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h View 1 chunk +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp View 1 chunk +21 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.h View 1 chunk +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp View 1 chunk +22 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.h View 1 chunk +24 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +185 lines, -208 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.h View 1 chunk +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +73 lines, -81 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
peria
PTL
4 years, 1 month ago (2016-10-27 20:22:42 UTC) #5
haraken
LGTM
4 years, 1 month ago (2016-10-27 20:30:08 UTC) #6
bashi
lgtm
4 years, 1 month ago (2016-10-27 23:46:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454133002/1
4 years, 1 month ago (2016-10-28 04:45:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/57598)
4 years, 1 month ago (2016-10-28 05:28:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454133002/1
4 years, 1 month ago (2016-10-28 06:08:19 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/291795)
4 years, 1 month ago (2016-10-28 06:16:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454133002/20001
4 years, 1 month ago (2016-10-28 07:51:28 UTC) #19
Yuki
lgtm
4 years, 1 month ago (2016-10-28 09:13:11 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 09:24:05 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 09:26:34 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/807695c59479aaaec619bb72c60a32f1c6adb779
Cr-Commit-Position: refs/heads/master@{#428323}

Powered by Google App Engine
This is Rietveld 408576698