Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2454123003: count timeout as a completed attempt. (Closed)
Patch Set: merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index 75841d27631a7cd5cb6c553f76f2ebf5d6566383..b9c710c2e66e6f1245a12712b236b8e1d68dec7c 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -1090,8 +1090,6 @@ TEST_F(RequestCoordinatorTest, WatchdogTimeoutForScheduledProcessing) {
EXPECT_FALSE(is_starting());
EXPECT_TRUE(OfflinerWasCanceled());
- EXPECT_EQ(Offliner::RequestStatus::REQUEST_COORDINATOR_TIMED_OUT,
- last_offlining_status());
}
TEST_F(RequestCoordinatorTest, WatchdogTimeoutForImmediateProcessing) {
@@ -1134,10 +1132,7 @@ TEST_F(RequestCoordinatorTest, WatchdogTimeoutForImmediateProcessing) {
PumpLoop();
// Verify the request timed out.
- EXPECT_FALSE(coordinator()->is_busy());
EXPECT_TRUE(OfflinerWasCanceled());
- EXPECT_EQ(Offliner::RequestStatus::REQUEST_COORDINATOR_TIMED_OUT,
- last_offlining_status());
}
TEST_F(RequestCoordinatorTest, TimeBudgetExceeded) {
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698