Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2454123003: count timeout as a completed attempt. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index df195f785f2a3398eef76d59ef4cea19a746fbf8..0cd66cab92473cfa2d15a70c399d4dd096790e61 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -1074,8 +1074,6 @@ TEST_F(RequestCoordinatorTest, WatchdogTimeoutForScheduledProcessing) {
EXPECT_FALSE(is_starting());
EXPECT_TRUE(OfflinerWasCanceled());
- EXPECT_EQ(Offliner::RequestStatus::REQUEST_COORDINATOR_TIMED_OUT,
- last_offlining_status());
}
TEST_F(RequestCoordinatorTest, WatchdogTimeoutForImmediateProcessing) {
@@ -1116,10 +1114,7 @@ TEST_F(RequestCoordinatorTest, WatchdogTimeoutForImmediateProcessing) {
PumpLoop();
// Verify the request timed out.
- EXPECT_FALSE(coordinator()->is_busy());
EXPECT_TRUE(OfflinerWasCanceled());
- EXPECT_EQ(Offliner::RequestStatus::REQUEST_COORDINATOR_TIMED_OUT,
- last_offlining_status());
}
TEST_F(RequestCoordinatorTest, TimeBudgetExceeded) {

Powered by Google App Engine
This is Rietveld 408576698